Closed
Bug 1025900
Opened 10 years ago
Closed 10 years ago
Include intrin.h directly in Atomics.h instead of declaring functions manually from it
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
3.52 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This is basically more of bug 1022049.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8440686 -
Flags: review?(nfroyd)
Comment 2•10 years ago
|
||
Comment on attachment 8440686 [details] [diff] [review] Include intrin.h directly in Atomics.h instead of declaring functions manually from it Review of attachment 8440686 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the changes below. ::: mfbt/Atomics.h @@ +628,5 @@ > }; > > # if defined(_M_X64) > > +# include <intrin.h> You don't need this one. @@ +688,5 @@ > }; > > # endif > > +# include <intrin.h> Or this one.
Attachment #8440686 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/51144145675e
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/51144145675e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•