make utility modules in apps consistent



Input Graveyard
Code Quality
3 years ago
7 months ago


(Reporter: willkg, Assigned: aokoye, Mentored)



(Whiteboard: [good first bug])

fjord/analytics/ has a module.
fjord/base/ has a module.
fjord/feedback/ has a module.
fjord/search/ has a module.
fjord/translations/ has a module.

I think we want to go with "" as a convention. Therefore:

1. fjord/analytics/ needs to be renamed to fjord/analytics/
2. fjord/base/ needs to be renamed to fjord/base/

This covers filename changes but also updating the code and test code to use the new module name.
Making this a mentored bug. This should be pretty straight forward--it's all in Python land.

If you're interested in working on this bug, let me know in the comments on this bug or on IRC (I'm willkg).
Whiteboard: [mentor=willkg]
Whiteboard: [mentor=willkg] → [mentor=willkg][good first bug]


3 years ago
Whiteboard: [mentor=willkg][good first bug] → [good first bug]

Comment 2

3 years ago
I'm interested on working on this bug. My current understanding is that I need to change the and modules to as well as updating and testing the code. I've found the code in the Mozilla's Fjord repo on Github and read much of the documentation.

I have built the vm set up Fjord and would like to start working on this bug by renaming fjord/base/ to fjord/base/ (I'm assuming there is a typo in the description) and fjord/analytics/ to fjord/analytics/ and then delve into the code from there. I'm also currently lurking in the #input IRC channel.
Sorry about that--I was at dinner when you pinged me on IRC.

If you've got a vm set up, you should be all set to work on this, thus I'm assigning it to you now.

I'm in Eastern time which is a few hours off from you (assuming you're in Portland). Feel free to ping me on IRC or via bug comments if you bump into anything. Looking forward to this oddity being sorted out. :)
Assignee: nobody → aokoye

Comment 4

3 years ago
PR made on Github -
Changed the various modules to in:

We want to change the names of the associated test modules to match, so I'm going to leave this open until that's done.

Comment 6

3 years ago
I changed the names test modules to keep with the convention and made a PR on Github -

Comment 7

3 years ago
A second, slightly different, pull request made and landed -
Pushed to prod just now. Yay!
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.