Make StyleRule::mDOMRule and StyleRule::mImportantRule into nsRefPtrs

RESOLVED FIXED in mozilla33

Status

()

Core
DOM: CSS Object Model
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Assignee: nobody → continuation
(Assignee)

Comment 1

4 years ago
Created attachment 8446028 [details] [diff] [review]
part 1 - Make StyleRule::mDOMRule into an nsRefPtr.

try: https://tbpl.mozilla.org/?tree=Try&rev=ff1ece740d55
Attachment #8446028 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

4 years ago
Created attachment 8446029 [details] [diff] [review]
part 2 - Make StyleRule::mImportantRule into an nsRefPtr.
Attachment #8446029 - Flags: review?(bzbarsky)
Comment on attachment 8446028 [details] [diff] [review]
part 1 - Make StyleRule::mDOMRule into an nsRefPtr.

I guess with the StyleRule dtor out of line this works.  r=me
Attachment #8446028 - Flags: review?(bzbarsky) → review+
Comment on attachment 8446029 [details] [diff] [review]
part 2 - Make StyleRule::mImportantRule into an nsRefPtr.

r=me
Attachment #8446029 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/15b7cbf6a9f5
https://hg.mozilla.org/mozilla-central/rev/9da5ee22c228
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.