1026100 - profileHDDModel & profileHDDRevision Telemetry fields are missing

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Vladan Djeric (:vladan)]

I see the profileHDDModel and profileHDDRevision fields in my Firefox Release 30, but they're missing from Nightly 33.

Confirmed on Windows 7 & Windows 8.1.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Something has changed such that we are not yet able to resolve the profile directory when nsSystemInfo::Init() is invoked. I'll have to look further into this as I do not see any smoking guns.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Add profile-do-change observer to nsSystemInfo

This patch attempts to add profile-specific data in a profile-do-change observer if we fail to do so during nsSystemInfo::Init.

Comment 3

[Benjamin Smedberg]

Comment on attachment 8445984 [details] [diff] [review]
Add profile-do-change observer to nsSystemInfo

>diff --git a/xpcom/base/nsSystemInfo.h b/xpcom/base/nsSystemInfo.h

>-class nsSystemInfo : public nsHashPropertyBag {
>+class nsSystemInfo : public nsHashPropertyBag
>+#if defined(XP_WIN)
>+                   , public nsIObserver
>+#endif // defined(XP_WIN)
>+{

Fix the styling while you're touching this:

class nsSystemInfo
  : public nsHashPropertyBag
#ifdef ...
  , public nsIObserver
#endif
{

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e4201be6c45

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Add profile-do-change observer to nsSystemInfo

Patch as landed

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e4201be6c45