Closed Bug 1026100 Opened 5 years ago Closed 5 years ago

profileHDDModel & profileHDDRevision Telemetry fields are missing

Categories

(Toolkit :: Telemetry, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: vladan, Assigned: aklotz)

Details

Attachments

(1 file, 1 obsolete file)

I see the profileHDDModel and profileHDDRevision fields in my Firefox Release 30, but they're missing from Nightly 33.

Confirmed on Windows 7 & Windows 8.1.
Something has changed such that we are not yet able to resolve the profile directory when nsSystemInfo::Init() is invoked. I'll have to look further into this as I do not see any smoking guns.
This patch attempts to add profile-specific data in a profile-do-change observer if we fail to do so during nsSystemInfo::Init.
Attachment #8445984 - Flags: review?(benjamin)
Comment on attachment 8445984 [details] [diff] [review]
Add profile-do-change observer to nsSystemInfo

>diff --git a/xpcom/base/nsSystemInfo.h b/xpcom/base/nsSystemInfo.h

>-class nsSystemInfo : public nsHashPropertyBag {
>+class nsSystemInfo : public nsHashPropertyBag
>+#if defined(XP_WIN)
>+                   , public nsIObserver
>+#endif // defined(XP_WIN)
>+{

Fix the styling while you're touching this:

class nsSystemInfo
  : public nsHashPropertyBag
#ifdef ...
  , public nsIObserver
#endif
{
Attachment #8445984 - Flags: review?(benjamin) → review+
Patch as landed
Attachment #8445984 - Attachment is obsolete: true
Attachment #8448482 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/6e4201be6c45
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.