1026122 - [dev][stage] new account creation - mark Location as a required field, enhance error messages

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - screenshot of dates on stage

During the new account creation process [/user/edit] `Your location` field is not marked as a required field yet new account creation fails if this field is empty.

STR:
0. create a new account
1. leave `Your location` empty when submitting the form

Expected:
Location data is not required

Actual:
Form submittable of /user/edit without a location set fails. Note there is not asterisk next to the `Your location` field

Comment 1

[William Reynolds [:williamr]]

We currently require a user to provide their country on production. With the new geographic fields, we still want to require country.

Suggested fix:
- Add a red asterisk next to the 'Country' label.
- Change the error message to 'Country cannot be empty.'

I don't think this is a release blocker. Wray, do you want to work on this one?

Nice find, Matt!

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/7965a0784ab218481753130466f13158a81b852e
[fix bug 1026122] Require country, improve location error messages.

https://github.com/mozilla/mozillians/commit/ea6b350450b74d2fcbc49f97190a1c03174c67c2
Merge pull request #983 from glogiotatidis/1026122

[fix bug 1026122] Require country, improve location error messages.

Comment 3

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened - feature suggestions

The current location of the asterisk and error message are disingenuous. The country field is not editable directly, the map is the only way to update this field.

Suggestion - move the red asterisk and error message to the `You location` line

Comment 4

[William Reynolds [:williamr]]

(In reply to Matt Brandt [:mbrandt] from comment #3)
> The current location of the asterisk and error message are disingenuous. 
Good point.

> Suggestion - move the red asterisk and error message to the `You location`
> line

To make it clear that the country is required, I think it would be useful to have the red asterisk next to both the 'Your location' and 'Country' strings. I also like that the word 'Require' appears in red, though if that is difficult to keep, it does not need to be red.

Makes sense to move the error message to appear next to 'Your location' so the user knows they need to interact with the map. Alternatively, we could change the error message to be more descriptive. Something like: 'Search for your country on the map'

Comment 5

[William Reynolds [:williamr]]

Also, this bug does not block the release.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

Attachment: screenshot-127 0 0 1 8000 2014-06-30 16-05-14.png

How do you like this one?

Comment 7

[Matt Brandt [:mbrandt]]

woot ya +1 from QA on comment 6

Comment 8

[William Reynolds [:williamr]]

Splendid, thanks Giorgos!

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/2bf4180861a33c0476bb7d57e310e8cac7f2c29a
[fix bug 1026122] Better error messages for location in /user/edit.

https://github.com/mozilla/mozillians/commit/d7124704e3a0f51852ecffbba82308a801fe7975
Merge pull request #1003 from glogiotatidis/1026122v2

[fix bug 1026122] Better error messages for location in /user/edit.

Comment 10

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on dev

QA verified on dev -- the enhanced error messages are fantastic.

This doesn't appear to have landed on stage yet, is this scheduled going out in the `next` release this week?

Comment 11

[Giorgos Logiotatidis [:giorgos]]

It was merged late yesterday UTC so it wasn't pushed to stage. But yes if we can verify it will be included in the relaease. This is now on stage.

Comment 12

[Giorgos Logiotatidis [:giorgos]]

Attachment: qa - verified on stage