[dev][stage] new account creation - mark Location as a required field, enhance error messages

VERIFIED FIXED

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mbrandt, Assigned: giorgos)

Tracking

(Blocks: 1 bug)

2014-07.1

Details

Attachments

(5 attachments)

(Reporter)

Description

4 years ago
Created attachment 8440903 [details]
qa - screenshot of dates on stage

During the new account creation process [/user/edit] `Your location` field is not marked as a required field yet new account creation fails if this field is empty.

STR:
0. create a new account
1. leave `Your location` empty when submitting the form

Expected:
Location data is not required

Actual:
Form submittable of /user/edit without a location set fails. Note there is not asterisk next to the `Your location` field
We currently require a user to provide their country on production. With the new geographic fields, we still want to require country.

Suggested fix:
- Add a red asterisk next to the 'Country' label.
- Change the error message to 'Country cannot be empty.'

I don't think this is a release blocker. Wray, do you want to work on this one?

Nice find, Matt!
Flags: needinfo?(wbowling)
(Reporter)

Updated

4 years ago
Summary: [stage] new account creation - Location data in /user/edit/ should not be required → [dev][stage] new account creation - mark Location as a required field, enhance error messages
(Assignee)

Updated

4 years ago
Blocks: 920651
(Assignee)

Updated

4 years ago
Assignee: nobody → giorgos
Status: NEW → ASSIGNED
Flags: needinfo?(wbowling)

Comment 2

4 years ago
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/7965a0784ab218481753130466f13158a81b852e
[fix bug 1026122] Require country, improve location error messages.

https://github.com/mozilla/mozillians/commit/ea6b350450b74d2fcbc49f97190a1c03174c67c2
Merge pull request #983 from glogiotatidis/1026122

[fix bug 1026122] Require country, improve location error messages.

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Version: other → next
(Reporter)

Comment 3

4 years ago
Created attachment 8445279 [details]
qa - reopened - feature suggestions

The current location of the asterisk and error message are disingenuous. The country field is not editable directly, the map is the only way to update this field.

Suggestion - move the red asterisk and error message to the `You location` line
(Reporter)

Updated

4 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Matt Brandt [:mbrandt] from comment #3)
> The current location of the asterisk and error message are disingenuous. 
Good point.

> Suggestion - move the red asterisk and error message to the `You location`
> line

To make it clear that the country is required, I think it would be useful to have the red asterisk next to both the 'Your location' and 'Country' strings. I also like that the word 'Require' appears in red, though if that is difficult to keep, it does not need to be red.

Makes sense to move the error message to appear next to 'Your location' so the user knows they need to interact with the map. Alternatively, we could change the error message to be more descriptive. Something like: 'Search for your country on the map'
Also, this bug does not block the release.
(Assignee)

Comment 6

4 years ago
Created attachment 8447970 [details]
screenshot-127 0 0 1 8000 2014-06-30 16-05-14.png

How do you like this one?
Flags: needinfo?(williamr)
Flags: needinfo?(mbrandt)
(Reporter)

Comment 7

4 years ago
woot ya +1 from QA on comment 6
Flags: needinfo?(mbrandt)
Splendid, thanks Giorgos!
Flags: needinfo?(williamr)

Comment 9

4 years ago
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/2bf4180861a33c0476bb7d57e310e8cac7f2c29a
[fix bug 1026122] Better error messages for location in /user/edit.

https://github.com/mozilla/mozillians/commit/d7124704e3a0f51852ecffbba82308a801fe7975
Merge pull request #1003 from glogiotatidis/1026122v2

[fix bug 1026122] Better error messages for location in /user/edit.

Updated

4 years ago
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

4 years ago
Created attachment 8449019 [details]
qa - verified on dev

QA verified on dev -- the enhanced error messages are fantastic.

This doesn't appear to have landed on stage yet, is this scheduled going out in the `next` release this week?
Flags: needinfo?(giorgos)
(Assignee)

Comment 11

4 years ago
It was merged late yesterday UTC so it wasn't pushed to stage. But yes if we can verify it will be included in the relaease. This is now on stage.
Flags: needinfo?(giorgos)
(Assignee)

Comment 12

4 years ago
Created attachment 8449214 [details]
qa - verified on stage
(Assignee)

Updated

4 years ago
Status: RESOLVED → VERIFIED
(Assignee)

Updated

4 years ago
Version: next → 2014-06.6
(Assignee)

Updated

4 years ago
Version: 2014-06.6 → 2014-07.1
You need to log in before you can comment on or make changes to this bug.