getdimensions has no Marionette session to get device pixel ratio

RESOLVED FIXED

Status

Testing Graveyard
Eideticker
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1020246 introduced a regression in getdimensions by expecting a Marionette session to be active for getting the device pixel ratio. I think in this case we're not worried about the exact coordinates of the interaction so returning 1 when we have no Marionette session should be acceptable.
(Assignee)

Comment 1

3 years ago
Created attachment 8440940 [details] [diff] [review]
Return a default device pixel ratio if there's no Marionette session. v1.0
Attachment #8440940 - Flags: review?(wlachance)
Comment on attachment 8440940 [details] [diff] [review]
Return a default device pixel ratio if there's no Marionette session. v1.0

lgtm
Attachment #8440940 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

3 years ago
Landed in:
https://github.com/mozilla/eideticker/commit/3e65c3f168120dcdaf0a54415fbefe2330aad547
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.