1026154 - [B2G][Homescreen][E.me] E.me apps have square icons when adding them to the homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: Square.png

Description:
E.me app icons are incorrectly displayed as squares on the homescreen.

Repro Steps:
1) Update a Flame to 20140616040202
2) Connect to Wifi
3) Select the search field on the homescreen
4) Type 'Facebook'
5) Select any app e.g. 'Twitter'
6) Add the app to the homescreen

Actual:
The app icon is displayed as a square.

Expected:
The app icons are not square.

Environmental Variables:
Device: Flame
Build ID: 20140616040202
Gaia: dfc4703bb81d1fa4f2087a1a6124b47a80a5d1de
Gecko: 80431d4fd0da
Version: 33.0a1  
Firmware Version: v121-2

User Agent: Mozilla/5.0 (Mobile;rv:33.0) Gecko/33.0 Firefox/33.0

Notes:
Repro frequency: 100%
See attached: Screenshot

Comment 1

[Josh Schmitt [Joshs]]

Issue repros on 2.0 Flame

Adding qawanted to test other branches/devices.

Environmental Variables:
Device: Flame
Build ID: 20140616000203
Gaia: a6988c15b361938bea5976c846c147ecdc1121c0
Gecko: 52a276202888
Version: 32.0a2 (2.0) 
Firmware Version: v121-2

User Agent: Mozilla/5.0 (Mobile;rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Joshua Mitchell (Inactive)]

QA-Wanted to test other branches/devices.

Comment 3

[Kevin Grandon :kgrandon]

I believe this was fixed this morning by landing: https://github.com/mozilla-b2g/gaia/commit/b9a8c783f7036c86f2035be26d3677e7d10a8f9e

It will likely be uplifted tomorrow morning and should be in Wednesday's nightly 2.0 build. (You should be able to verify that it works in master now though).

Comment 4

[Joshua Mitchell (Inactive)]

QA-Wanted : hold off on the branch testing for now, let's check repro on the latest master instead.

Comment 5

[Natalya Kot [:nkot]]

Attachment: screenshot_latest_master

(In reply to Kevin Grandon :kgrandon from comment #3)
> I believe this was fixed this morning by landing:
> https://github.com/mozilla-b2g/gaia/commit/
> b9a8c783f7036c86f2035be26d3677e7d10a8f9e
> 
> It will likely be uplifted tomorrow morning and should be in Wednesday's
> nightly 2.0 build. (You should be able to verify that it works in master now
> though).

It doesn't work in master, app icons are displayed as squares in today's latest build... Should we reopen the bug?

Flame master m-c
BuildID: 20140617040203
Gaia: eac13407742a55b11e1877b4df2abdfd22cd582e
Gecko: bb35d1b73634
Version: 33.0a1
V121-2

Comment 6

[Cody Roesch [:croesch]]

Verified with the latest Flame 2.1 build and the patch provided in comment 3, that this bug no longer occurs.

Environmental Variables:
Device: Flame 2.1 - Master
Build ID: 20140617040203
Gaia: 87b2ce54bac96fe2569f7ffb812a3c8fa01af0be
Gecko: bb35d1b73634
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v121-2

Comment 7

[Joshua Mitchell (Inactive)]

some inconsistent results from our pull-process - we will retest tomorrow (Wednesday) as per comment 3

Comment 8

[Joshua Mitchell (Inactive)]

okay, this is verified fixed today using any method to pull builds-

Latest Master Env. Variables

Environmental Variables:
Device: Flame 2.1 - Master
Build ID: 20140618053937
Gaia: 336c30b6147cdd9122ad0b2bbffb81eb869a9ec2
Gecko: 1cea544c74c5
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v121-2

Comment 9

[Verson Xiong (Leave from Mozilla)]

Attachment: Flame_V2.0_Verify1.png

This bug has been verified as "pass" on latest build of Flame 2.0 and per comment 6 it's verified successful on 2.1 build.
STR.
1) Update a Flame to latest build.
2) Connect to Wifi
3) Select the search field on the homescreen
4) Type 'social'
5) Select any app e.g. 'Twitter'
6) Add the app to the homescreen

Actually result:Bookmark icon is displayed as round.
Reproduce rate: 0/10
See attachment: Flame_V2.0_Verify1.png

Device: Flame 2.0 (pass):
Build ID               20150713160205
Gaia Revision          b16ba05481e577bc644ed8966f587a70fe2148e6
Gaia Date              2015-07-07 22:41:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/43b0dbfbf82b
Gecko Version          32.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150713.200128
Firmware Date          Mon Jul 13 20:01:40 EDT 2015
Bootloader             L1TC000118D0