Closed
Bug 1026239
Opened 10 years ago
Closed 10 years ago
Replace community participation with a font awesome icon
Categories
(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brett, Assigned: alicoding)
References
Details
(Whiteboard: [design] [july25])
Attachments
(1 file)
So one of the competencies in /resources is actually a custom icon, see https://wiki.mozilla.org/File:Communityparticipation3.png Since this isn't a font awesome logo we'll need to find a different way to add it to the /resources section.
|
||
Comment 1•10 years ago
|
||
Since this is the only one that isn’t in the icon font, is there any way we can change the community participation icon instead of rewriting the entire code?
Flags: needinfo?(brett)
|
Reporter | |
Comment 2•10 years ago
|
||
OK, I'm going to ask we revisit this one and find an appropriate font awesome icon
Assignee: aki → cassie
Flags: needinfo?(brett)
Summary: Add support in resources template for a custom icon → Replace community participation with a font awesome icon
|
||
Comment 4•10 years ago
|
||
What about speech bubbles? http://fortawesome.github.io/Font-Awesome/icon/comments Doesn't appear we've used that anywhere (see https://wiki.mozilla.org/Webmaker/Badges/Webliteracy ) Since Jess is away, Matt can you review?
Status: NEW → ASSIGNED
Flags: needinfo?(matt)
|
||
Comment 5•10 years ago
|
||
* Works for me!
Flags: needinfo?(matt)
Whiteboard: [july11] → [design] [july11]
|
|
Reporter | |
Comment 6•10 years ago
|
||
works for me, too!
|
||
Comment 7•10 years ago
|
||
We used a single speech bubble for the 'Connecting' badge as part of Webmaker Training, but I don't see it as a blocker: https://wiki.mozilla.org/Webmaker/Badges/Participation
|
|
||
Updated•10 years ago
|
Whiteboard: [design] [july11] → [design] [july25]
|
|
||
Comment 8•10 years ago
|
||
* Cassie: can we assign this to someone else to close this out?
Flags: needinfo?(cassie)
|
|
||
Comment 9•10 years ago
|
||
Assigning to Ali. Just need to add this icon: http://fortawesome.github.io/Font-Awesome/icon/comments to this page: https://webmaker.org/resources/literacy/weblit-Community as on the other resources pages.
Assignee: cassie → ali
Flags: needinfo?(cassie)
|
Assignee | |
Comment 10•10 years ago
|
||
Attachment #8458001 -
Flags: review?(aki)
|
|
||
Comment 11•10 years ago
|
||
Comment on attachment 8458001 [details] https://github.com/mozilla/webmaker.org/pull/885 Is this supposed to be a Github link?
Flags: needinfo?(ali)
|
|
Assignee | |
Comment 12•10 years ago
|
||
Comment on attachment 8458001 [details] https://github.com/mozilla/webmaker.org/pull/885 https://github.com/mozilla/webmaker.org/pull/885
Attachment #8458001 -
Attachment description: https://bugzilla.mozilla.org/show_bug.cgi?id=1026239 → https://github.com/mozilla/webmaker.org/pull/885
|
|
||
Updated•10 years ago
|
Attachment #8458001 -
Flags: review?(aki) → review-
|
|
||
Comment 14•10 years ago
|
||
Left some comments on the PR. With screen shots!
|
|
Assignee | |
Comment 15•10 years ago
|
||
Aki I'm seeing this though... >..< https://dl.dropboxusercontent.com/spa/n5v3bx9nnjkdpzf/emo66w0t.png
Flags: needinfo?(aki)
|
|
||
Updated•10 years ago
|
Attachment #8458001 -
Flags: review- → review+
Flags: needinfo?(aki)
|
||
Comment 16•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/3d2c68059ca5000225f57483e4b2937d34f7c2ef bug1026239 - Add font-awesome icon to community
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•