1026269 - [Rocketbar] URL is being passed to Google, not search terms

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Francis Djabri [:djabber]]

Attachment: URL is shown in Google search field

If Google is set as the default search provider, and the user enters in search terms that are separated by a space, the Google results show a URL in the Google search box and not the search terms that the user entered. 

Steps to reproduce from Home:
Pre-conditions: Google set as default search provider
1) Tap search field
2) Enter in two or more search terms separated by a space
3) tap Enter

Expected results:
Search terms are shown in the search field in the Google results page

Actual results: 
A URL is shown in the search field

Comment 1

[Francis Djabri [:djabber]]

Set to blocking as this doesn't complete the search that the user was intending

Comment 2

[Gregor Wagner [:gwagner]]

Ben, Dale, can you take a look here?

Comment 3

[Dale Harvey (:daleharvey)]

Yeh will take this

Comment 5

[Ben Francis [:benfrancis]]

Probably just need to URL encode the constructed search URL before passing it via the web activity (see https://bugzilla.mozilla.org/show_bug.cgi?id=1025698#c9)

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20705

Yeh just needed encoding

This feature as a whole really needs integration tests, but didnt want to block this bug on it, but will follow up in another bug with some more testing

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 8442303 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20705

Clearing review until I implement tests

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 8442303 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20705

Tests added, switch r? to kevin because timezones

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8442303 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20705

Darn timezones. This looks good, R+ assuming travis or gaia-try is green.

Comment 11

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/7e0ee26ab10fe5d831d58a0398733676bd6d2381

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64e4c08aaf7c

Comment 13

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/34613df564b7899b1d6b8027c7abf860d70a8466

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia      9d2f7bd16a8dc0c74c97c5a40d2f0731f3dfff4b
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/f118b45daada
BuildID   20140624000201
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
flame 

Gaia      45479c07cb6ba8c733093d6ee32c767c090c9a28
Gecko     https://hg.mozilla.org/mozilla-central/rev/e86b84998b18
BuildID   20140624040203
Version   33.0a1
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
flame

Verified that it works on 2.0, ran into bug 1029567 on 2.1; flashed my own gaia on top for 2.1 confirmation after backout:
gaia commit 756f1ae83413fe6bf5e8b6f985fb03da1bab02d4