Closed
Bug 1026272
Opened 10 years ago
Closed 10 years ago
Style Editor sidebar can be resized narrower than its contents
Categories
(DevTools :: Style Editor, defect)
DevTools
Style Editor
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 34
People
(Reporter: bgrins, Assigned: m.pranav)
Details
(Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"])
Attachments
(2 files, 2 obsolete files)
20.44 KB,
image/png
|
Details | |
665 bytes,
patch
|
Details | Diff | Splinter Review |
See screenshot
Updated•10 years ago
|
Assignee: nobody → fayearthur
Comment 1•10 years ago
|
||
I put a min-width on it in bug 1025693
Comment 2•10 years ago
|
||
There's a min-width now, but it's a little too high as the gear icon still sticks out a bit.
Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"]
Updated•10 years ago
|
Assignee: fayearthur → nobody
Comment 4•10 years ago
|
||
Hi Pranav, Thanks. You can reproduce this bug by resizing the sidebar in the Style Editor. The gear icon might only stick out on Mac, but we should make sure it's not possible to resize it past that, so that it will always show all the buttons in the toolbar. Notice that we do already put a limit on it. If you try resizing it all the way it will stop after a certain point. This was from bug 1025693. We just need to increase that min-width.
patch with increased min-width.
Attachment #8468698 -
Flags: review?(fayearthur)
Comment 6•10 years ago
|
||
Comment on attachment 8468698 [details] [diff] [review] Bug1026272 increased min-width. Review of attachment 8468698 [details] [diff] [review]: ----------------------------------------------------------------- This is making go from 200px to 180px, a decrease.
Attachment #8468698 -
Flags: review?(fayearthur) → review-
Attachment #8469055 -
Flags: review?(fayearthur)
Comment 8•10 years ago
|
||
Changed the commit message to "Bug 1026272 - Style Editor sidebar can be resized narrower than its contents; r=harth" and the author to "Pranav <m.pranav@ymail.com>". Thanks Pranav!
Attachment #8468698 -
Attachment is obsolete: true
Attachment #8469055 -
Attachment is obsolete: true
Attachment #8469055 -
Flags: review?(fayearthur)
Updated•10 years ago
|
Attachment #8469055 -
Flags: review+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a8c1fe0aec46
Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"] → [good-first-bug][mentor="fayearthur@gmail.com"][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a8c1fe0aec46
Assignee: nobody → m.pranav
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"][fixed-in-fx-team] → [good-first-bug][mentor="fayearthur@gmail.com"]
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
QA Whiteboard: [good first verify]
Flags: qe-verify+
Comment 11•10 years ago
|
||
Verified on MacOSX FF 33.0a2 that the buttons always show in the style editor toolbar- yes the gear icon sticks out a little but is functional.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•