Style Editor sidebar can be resized narrower than its contents

VERIFIED FIXED in Firefox 34

Status

defect
VERIFIED FIXED
5 years ago
Last year

People

(Reporter: bgrins, Assigned: m.pranav)

Tracking

Trunk
Firefox 34
Bug Flags:
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"])

Attachments

(2 attachments, 2 obsolete attachments)

Reporter

Description

5 years ago
See screenshot
Assignee: nobody → fayearthur
I put a min-width on it in bug 1025693
There's a min-width now, but it's a little too high as the gear icon still sticks out a bit.
Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"]
Assignee: fayearthur → nobody
Assignee

Comment 3

5 years ago
Hi 
I would like to work on this bug
Hi Pranav, Thanks. You can reproduce this bug by resizing the sidebar in the Style Editor. The gear icon might only stick out on Mac, but we should make sure it's not possible to resize it past that, so that it will always show all the buttons in the toolbar.

Notice that we do already put a limit on it. If you try resizing it all the way it will stop after a certain point. This was from bug 1025693. We just need to increase that min-width.
Assignee

Comment 5

5 years ago
patch with increased min-width.
Attachment #8468698 - Flags: review?(fayearthur)
Comment on attachment 8468698 [details] [diff] [review]
Bug1026272 increased min-width.

Review of attachment 8468698 [details] [diff] [review]:
-----------------------------------------------------------------

This is making go from 200px to 180px, a decrease.
Attachment #8468698 - Flags: review?(fayearthur) → review-
Assignee

Comment 7

5 years ago
Attachment #8469055 - Flags: review?(fayearthur)
Changed the commit message to "Bug 1026272 - Style Editor sidebar can be resized narrower than its contents; r=harth" and the author to "Pranav <m.pranav@ymail.com>".

Thanks Pranav!
Attachment #8468698 - Attachment is obsolete: true
Attachment #8469055 - Attachment is obsolete: true
Attachment #8469055 - Flags: review?(fayearthur)
Attachment #8469055 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/a8c1fe0aec46
Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"] → [good-first-bug][mentor="fayearthur@gmail.com"][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a8c1fe0aec46
Assignee: nobody → m.pranav
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor="fayearthur@gmail.com"][fixed-in-fx-team] → [good-first-bug][mentor="fayearthur@gmail.com"]
Target Milestone: --- → Firefox 34
QA Whiteboard: [good first verify]
Flags: qe-verify+
Verified on MacOSX FF 33.0a2 that the buttons always show in the style editor toolbar- yes the gear icon sticks out a little but is functional.
Status: RESOLVED → VERIFIED

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.