1026272 - Style Editor sidebar can be resized narrower than its contents

Status: VERIFIED FIXED

(DevTools :: Style Editor, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: style-editor-small-sidebar.png

See screenshot

Comment 1

[Heather Arthur [:harth]]

I put a min-width on it in bug 1025693

Comment 2

[Heather Arthur [:harth]]

There's a min-width now, but it's a little too high as the gear icon still sticks out a bit.

Comment 3

[pranav]

Hi 
I would like to work on this bug

Comment 4

[Heather Arthur [:harth]]

Hi Pranav, Thanks. You can reproduce this bug by resizing the sidebar in the Style Editor. The gear icon might only stick out on Mac, but we should make sure it's not possible to resize it past that, so that it will always show all the buttons in the toolbar.

Notice that we do already put a limit on it. If you try resizing it all the way it will stop after a certain point. This was from bug 1025693. We just need to increase that min-width.

Comment 5

[pranav]

Attachment: Bug1026272 increased min-width.

patch with increased min-width.

Comment 6

[Heather Arthur [:harth]]

Comment on attachment 8468698 [details] [diff] [review]
Bug1026272 increased min-width.

Review of attachment 8468698 [details] [diff] [review]:
-----------------------------------------------------------------

This is making go from 200px to 180px, a decrease.

Comment 7

[pranav]

Attachment: BUG1026272 This is the correct patch

Comment 8

[Heather Arthur [:harth]]

Attachment: Patch for checkin

Changed the commit message to "Bug 1026272 - Style Editor sidebar can be resized narrower than its contents; r=harth" and the author to "Pranav <[e-mail]>".

Thanks Pranav!

Comment 9

[Heather Arthur [:harth]]

https://hg.mozilla.org/integration/fx-team/rev/a8c1fe0aec46

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a8c1fe0aec46

Comment 11

[Rebecca Billings [:rbillings]]

Verified on MacOSX FF 33.0a2 that the buttons always show in the style editor toolbar- yes the gear icon sticks out a little but is functional.