Closed Bug 1026273 Opened 10 years ago Closed 10 years ago

[Vertical Homescreen] Smart collections are sometimes added in a random order

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S4 (20june)
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: jlorenzo, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Github pull request
46 bytes, text/x-github-pull-request
amirn
: review+
bajaj
: approval-gaia-v2.0+
Details | Review
verified_v2.0.MP4
4.19 MB, video/mp4
Details 
Steps to reproduce
1. Long press an empty space of the homescreen
2. Add Smart Collection
3. In alphabetical order, select: Movies, Music, News, Photography, Shopping.

Actual result
When done, the homescreen order seems to be determined by the download order (like Movies was the last in my Homescreen).

Expected result
To be determined. Having the icons displayed in the same order as the list seems to be less confusing though.
What do you think Jacqueline?
Flags: needinfo?(jsavory)
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Yes I agree that the icons should appear in the order of the list. In this case the list is alphabetical so they should appear alphabetically.
Flags: needinfo?(jsavory)
Whiteboard: [systemsfe]
Component: Gaia::Homescreen → Gaia::Everything.me
Vertical home paints collections with the insertion order in the datastore so I think that it should be done in collection app
Blocks: vertical-home-next
No longer blocks: 1015336
This is needed for bug 1022985, so taking.
Assignee: nobody → kgrandon
Blocks: 1022985
No longer blocks: vertical-home-next
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0 S4 (20june)
Attached file Github pull request — 

    
    

    
  
Comment on attachment 8442665 [details] [review]
Github pull request

Hey guys - got time for a review?

        Attachment #8442665 -
        Flags: review?(ran)

        Attachment #8442665 -
        Flags: review?(amirn)

    
    

    
  
Comment on attachment 8442665 [details] [review]
Github pull request

works as expected, minor comments on Github.

I would be happy if we could think of a less complex solution for this, but if nothing else comes to mind lets go with this one.

Thanks Kevin.

        Attachment #8442665 -
        Flags: review?(amirn) → review+

    
  

        Attachment #8442665 -
        Flags: review?(ran)

    
    

    
  
Thanks for the review!

Landed: https://github.com/mozilla-b2g/gaia/commit/945edaab44bec265ea46e082f0f0adf5fe0d0c44
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8442665 [details] [review]
Github pull request

This is needed for the vertical homescreen.

        Attachment #8442665 -
        Flags: approval-gaia-v2.0?(bbajaj)
Keywords: verifyme

        Attachment #8442665 -
        Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+

    
  
Status: RESOLVED → VERIFIED

          status-b2g-v2.1:
          fixed → verified

    
    

    
  
This bug has been successfully verified on Flame v2.0.
See attachment: verified_v2.0.mp4.
Reproduce rate: 0/5.

STR:
1. Long press an empty space on the homescreen
2. Tap Add Smart Collection
3. Select some Smart Collections from list in alphabetical order.
**The Smart Collection icons display in the same order as the list.

Flame v2.0 build
Gaia-Rev        2989f2b2bd12fcc0e9c017d2db766e76a55873b8
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ef542c0d3101
Build-ID        20150127000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150127.032929
FW-Date         Tue Jan 27 03:29:40 EST 2015
Bootloader      L1TC000118D0

          status-b2g-v2.0:
          fixed → verified
Keywords: verifyme
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking-][VH-FC-blocking-],[MGSEI-Triage+]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: