If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove e.me as an available search engine and set new default in build

VERIFIED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Search
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: pdol, Assigned: kgrandon)

Tracking

unspecified
2.0 S4 (20june)
x86
Mac OS X

Firefox Tracking Flags

(feature-b2g:2.0, b2g-v2.0 fixed, b2g-v2.1 verified)

Details

(Whiteboard: [systemsfe],[priority])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
After meeting with e.me and going through the search plan in 2.0 and beyond, e.me has asked that they NOT be an available search engine for Rocketbar on homescreen, specifically after Enter press.

E.me, of course, would still be used as the user types but Enter press would take the user to one of the other search engines (based on what was configured in the build or what the user change the search engine to).

To be clear, the search engines available in the build (for now) should be: Google, Yahoo and Bing.  Google should be default, but of course this can be modified based on the market.
(Reporter)

Updated

3 years ago
Blocks: 989848
Based on dogfooding + exploratory testing, I'm not sure if we should consider having a default search engine. Most users appear to get confused when the enter operation produces different results than what is seen by autocomplete. Why not just return what is seen by autocomplete after hitting enter with the current search term?
Flags: needinfo?(pdolanjski)
(Reporter)

Comment 2

3 years ago
Francis?
Flags: needinfo?(pdolanjski) → needinfo?(fdjabri)
Assignee: nobody → bfrancis
(In reply to Jason Smith [:jsmith] from comment #1)
> Based on dogfooding + exploratory testing, I'm not sure if we should
> consider having a default search engine. Most users appear to get confused
> when the enter operation produces different results than what is seen by
> autocomplete. Why not just return what is seen by autocomplete after hitting
> enter with the current search term?

Removing search terms may be confusing in the case of e.me when pressing enter, but opening a browser window and providing a list of search terms from one of the other default search providers would provide value and is what users are expecting based on the usability testing that we've done.
Flags: needinfo?(fdjabri)
Created attachment 8441601 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20632
Attachment #8441601 - Flags: review?(kgrandon)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8441601 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20632

Seems to work fine, thanks!
Attachment #8441601 - Flags: review?(kgrandon) → review+
Peter - Does this need to block 2.0? The bug reads off as something we need to do in the 2.0 timeframe.
QA Whiteboard: [VH-FL-blocking?][VH-FC-blocking?]
Flags: needinfo?(pdolanjski)
(Reporter)

Comment 7

3 years ago
(In reply to Jason Smith [:jsmith] from comment #6)
> Peter - Does this need to block 2.0? The bug reads off as something we need
> to do in the 2.0 timeframe.

Yes, it's probably the best course of action to block to avoid partner issues.
blocking-b2g: backlog → 2.0?
Flags: needinfo?(pdolanjski)

Updated

3 years ago
QA Whiteboard: [VH-FL-blocking?][VH-FC-blocking?] → [VH-FL-blocking+][VH-FC-blocking+]
blocking-b2g: 2.0? → ---
feature-b2g: --- → 2.0
(Assignee)

Comment 8

3 years ago
Yuren - could you help us look into the maxBuffer issue we're seeing with this patch? Thanks!
Flags: needinfo?(yurenju.mozilla)
(Assignee)

Comment 9

3 years ago
I think I found the problem, json syntax error. Let's see if this works and if not I'll open the ni? again.

Taking, but will likely just squash my changes into Ben's.
Assignee: bfrancis → kgrandon
Flags: needinfo?(yurenju.mozilla)
Target Milestone: --- → 2.0 S4 (20june)
(Assignee)

Comment 10

3 years ago
Turns out there was an extra comma at the end of the JSON structure. I'm not sure why it gave the max buffer problem, I guess perhaps it was throwing a stack and overflowed the buffer?
(Assignee)

Comment 11

3 years ago
Got a green run and landed: https://github.com/mozilla-b2g/gaia/commit/bcb2115984ffdabc873f392678723f151cd880fd
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 12

3 years ago
Comment on attachment 8441601 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20632

This is needed for the vertical homescreen.
Attachment #8441601 - Flags: approval-gaia-v2.0?(bbajaj)
Google is now the default one.
Status: RESOLVED → VERIFIED
status-b2g-v2.1: --- → verified

Updated

3 years ago
Attachment #8441601 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
(Assignee)

Comment 14

3 years ago
2.0: https://github.com/mozilla-b2g/gaia/commit/1b427aab595b6092cc6ccaeb5a9e65436bd93d8c
status-b2g-v2.0: --- → fixed
You need to log in before you can comment on or make changes to this bug.