Closed Bug 1026323 Opened 8 years ago Closed 8 years ago

Add a test for an OMTA transition with a delay

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: birtles, Assigned: birtles)

Details

Attachments

(1 file)

At one point I remember seeing transitions with delays that failed to run when OMTA was enabled. I'm pretty sure it's fixed now, but we should have at least one OMTA-specific test for transitions with delays.
This patch adds a test for transitions with a delay that run on the compositor.
Currently animations (including transitions) are not sent to the compositor
until they reach the end of their delay phase introducing the possibility that
the behavior might differ for animations with or without delays.

This patch adds a simple test for a transition with a delay. It also fixes an
existing bug in the opacity test. Also, it moves the step where the "transition"
property is removed to the end of the test sequence rather than the end of the
opacity test (which previously happened to occur at the end of the test
sequence).
Attachment #8441103 - Flags: review?(dzbarsky)
Comment on attachment 8441103 [details] [diff] [review]
Add a test for a transition with a delay running on the compositor

Review of attachment 8441103 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about taking so long to get to this.  Looks good to me!
Attachment #8441103 - Flags: review?(dzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4d2010d1772

(In reply to David Zbarsky (:dzbarsky) from comment #2)
> Sorry about taking so long to get to this.  Looks good to me!

No problem. Thanks!
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/e4d2010d1772
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.