1026328 - [OPENC_1.3]No 'Sound' and 'Alert' selected in settings app any more after changing language.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[RuiLi]

User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36

Steps to reproduce:

1. Launch settings app and select “sound”.
2. Change 'Ringer', for example, to 'Classic Prism' and then tap done. Also, change 'Alert' sound.
3. Open 'Language' and change language to 'French' or any other language.
4. Reopen 'Sound' and 'Ringer' menu.

You'll find no any sound item selected, and so is 'Alert'.

Comment 1

[isabelrios]

This issue has been reproduced with 1.3 buri (06/16) build:
Gecko-1da5885
Gaia-7f361e6

And also, with master (06/17) buri build:
Gecko-82463f1
Gaia-f93e6fa

Comment 2

[isabelrios]

Attachment: English sound and alarm tones selected.png

Comment 3

[isabelrios]

Attachment: Changed to French no sound or alarm selected.png

Comment 4

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

De-nom since it is not a critical bug to block 1.3.

Hi Howie, could you find someone to check this setting problem? It can be reproduced on master as well

Thanks

Comment 5

[Beatriz Rodríguez [:brg]]

I would like to nominate the issue to be fixed in 2.0. Agree that we are late for 1.3.

Comment 6

[howie [:howie]]

This is something we should fix, but not a blocker, ni Dominic, can you help on this? Thanks.

Comment 7

[Dominic Kuo [:dkuo]]

Attachment: patch

EJ,

This issue is a lack of the ringtones work from 2.0, the patch is trivial that added the missing l10nId, would you please review it? thanks.

Comment 8

[Dominic Kuo [:dkuo]]

Hey EJ,

Thanks for finding the issue that we found in the offline discussion, I have addressed it and now the custom ringtone should not be localized but keep as it is, would you review it again? thanks.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Domi, just left a comment on Github and please check it ! Thanks :)

Comment 10

[Dominic Kuo [:dkuo]]

Thanks EJ and I have addressed the issue, mind to take a look again? thanks.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8444240 [details] [review]
patch

It looks nice ! r+

Thanks for the help, Domi !

Comment 12

[Dominic Kuo [:dkuo]]

master: 9007d3846dd46e04b1ef8eed92bc482260206511

Comment 13

[Juanjo Iglesias]

Tested with unagi master and working OK. 

Gecko-0112de7
Gaia-512f288

Comment 14

[Elie]

Attachment: VIDEO0155_Compress.MP4

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2