Closed Bug 1026373 Opened 10 years ago Closed 10 years ago

NFC: 'shrinking-rejected' event is not used anymore

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S4 (12sep)

People

(Reporter: allstars.chh, Assigned: kamituel)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Pull request
46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review 
Bug 1020005 renames 'shrinking-rejected' event to 'shrinking-stop' event, however everything else still remains un-modified, which is a problem.

apps/system/test/unit/shrinking_ui_test.js
apps/system/test/unit/orientation_manager_test.js
apps/system/js/shrinking_ui.js
apps/system/js/orientation_manager.js
assign to Sidd since he worked on Bug 1020005
Assignee: nobody → psiddh
Whiteboard: [good first bug]
I'll fix that.
Assignee: psiddh → kamituel
Attached file Pull request — 
Removes the unused shrinking-rejected event handling.
Attachment #8484116 - Flags: review?(gweng)
Attachment #8484116 - Flags: review?(gweng) → review+
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/c71fd5d8c9c7cb021c97e5e9fbb29f92b50a084d
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S4 (12sep)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: