Closed Bug 1026391 Opened 10 years ago Closed 9 years ago

Refactor and improve Email Preferences bugmail recipient verification

Categories

(Bugzilla :: QA Test Scripts, enhancement)

Product:
Bugzilla
Component:
QA Test Scripts
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: wicked, Assigned: dkl)

References

Details

Attachments

(1 file)

Refractor Email Preferences recipient verification, V1
12.25 KB, patch
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #635452 +++

This patch improves bugmail recipient verification in the problematic Email Preference test script by making these changes:
 1) Refractors the verification to a sub.
 2) Switches parameters to is_deeply() around to have a more logical output of expected and seen diagnostics if the arrays differ.
 3) In case of an error, extracts and shows the different roles for the bug to help investigate possible problems.
Attachment #8441210 - Flags: review?(dkl)
Sorry for how long this has waited. I went ahead and took your patch and updated it to match changes in the current test script and committed.

To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   cdb244a..e52547d  master -> master

dkl
Assignee: testing → dkl
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8441210 - Flags: review?(dkl)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: