1026392 - browser_ruleview_add-property-cancel_03.js | A promise chain failed to handle a rejection - unknownError

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

See the logs: https://tbpl.mozilla.org/php/getParsedLog.php?id=40626296&tree=Try&full=1#error79

Part of bug 1018184 that aims at removing all errors caused by unhandled rejected promises.

Comment 1

[Patrick Brosset <:pbro>]

03:55:58  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleinspector/test/browser_ruleview_add-property-cancel_03.js | A promise chain failed to handle a rejection - unknownError
03:55:58     INFO -  Stack trace:
03:55:58     INFO -      JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: PendingErrors.register :: line 164
03:55:58     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.completePromise :: line 670
03:55:58     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Promise.reject/< :: line 491
03:55:58     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Promise :: line 346
03:55:58     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Promise.reject :: line 491
03:55:58     INFO -  JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/styleinspector/rule-view.js :: promiseWarn :: line 45
03:55:58     INFO -  JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js :: reject :: line 48
03:55:58     INFO -  JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js :: then :: line 24
03:55:58     INFO -  JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js :: resolve :: line 72
03:55:58     INFO -  JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js :: reject :: line 49
03:55:58     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 866
03:55:58     INFO -  JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 742
03:55:58     INFO -  native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

Comment 2

[Patrick Brosset <:pbro>]

The unhandled promise rejection in fact comes from browser_ruleview_add-property-cancel_02.js but is reported late in browser_ruleview_add-property-cancel_03.js

Comment 3

[Patrick Brosset <:pbro>]

Attachment: bug1026392-unhandled-rejected-promise-browser_ruleview_add-property-cancel_02.js v1.patch

The test was updating styles in an 'element {}' rule, so every change was actually triggering a markup mutation too, which in turn was triggering events that the test wasn't waiting for.
I've simply changed the test to use a real stylesheet rule, cleaned it a little bit.
I've also made a quick change to Tooltip.js to prevent it from processing key events when not tooltip is visible. This was showing up several times in the logs when using the devtools.dump.emit flag.

Pending try build https://tbpl.mozilla.org/?tree=Try&rev=51c6ed066118

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/e4bb377a4b86

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4bb377a4b86