1026432 - MOZ_Assert: XRE_GetProcessType() != GeckoProcessType_Default at CompositorChild.cpp:95

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Gregor Wagner [:gwagner]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=41845303&tree=Pine&full=1#error1


22:47:39     INFO -   0  libxul.so!mozilla::layers::CompositorChild::Get() [CompositorChild.cpp:5ac8cc2c4064 : 95 + 0x2]
22:47:39     INFO -       r4 = 0x00000000    r5 = 0x475c46d4    r6 = 0xbea26794    r7 = 0xbea26970
22:47:39     INFO -       r8 = 0x00000000    r9 = 0xbea267ac   r10 = 0x00000001    fp = 0x475c46d4
22:47:39     INFO -       sp = 0xbea26608    lr = 0x4129f807    pc = 0x4129f808
22:47:39     INFO -      Found by: given as instruction pointer in context
22:47:39     INFO -   1  libxul.so!mozilla::layers::SharedFrameMetricsHelper::UpdateFromCompositorFrameMetrics(mozilla::layers::ContainerLayer*, bool, bool, mozilla::gfx::RectTyped<mozilla::ParentLayerPixel>&, mozilla::gfx::ScaleFactor<mozilla::CSSPixel, mozilla::ParentLayerPixel>&) [TiledContentClient.cpp:5ac8cc2c4064 : 149 + 0x3]
22:47:39     INFO -       r4 = 0x4680d800    r5 = 0x475c46d4    r6 = 0xbea26794    r7 = 0xbea26970
22:47:39     INFO -       r8 = 0x00000000    r9 = 0xbea267ac   r10 = 0x00000001    fp = 0x475c46d4
22:47:39     INFO -       sp = 0xbea26618    pc = 0x4128bdef
22:47:39     INFO -      Found by: call frame info
22:47:39     INFO -   2  libxul.so!mozilla::layers::ClientTiledLayerBuffer::ComputeProgressiveUpdateRegion(nsIntRegion const&, nsIntRegion const&, nsIntRegion&, mozilla::layers::BasicTiledLayerPaintData*, bool) [TiledContentClient.cpp:5ac8cc2c4064 : 963 + 0x17]
22:47:39     INFO -       r4 = 0x4680f9cc    r5 = 0xbea2680c    r6 = 0x475c46d8    r7 = 0xbea26970
22:47:39     INFO -       r8 = 0x00000000    r9 = 0xbea26750   r10 = 0x4680d800    fp = 0x475c46d4
22:47:39     INFO -       sp = 0xbea266f8    pc = 0x4128c10b
22:47:39     INFO -      Found by: call frame info
22:47:39     INFO -   3  libxul.so!mozilla::layers::ClientTiledLayerBuffer::ProgressiveUpdate(nsIntRegion&, nsIntRegion&, nsIntRegion const&, mozilla::layers::BasicTiledLayerPaintData*, void (*)(mozilla::layers::ThebesLayer*, gfxContext*, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*), void*) [TiledContentClient.cpp:5ac8cc2c4064 : 1098 + 0x13]
22:47:39     INFO -       r4 = 0xbea2680c    r5 = 0xbea267f8    r6 = 0xbea26970    r7 = 0x4680f990
22:47:39     INFO -       r8 = 0x00000000    r9 = 0x00000000   r10 = 0x475c46d8    fp = 0xbea268ac
22:47:39     INFO -       sp = 0xbea267f0    pc = 0x4128d59b
22:47:39     INFO -      Found by: call frame info
22:47:39     INFO -   4  libxul.so!mozilla::layers::ClientTiledThebesLayer::RenderHighPrecision(nsIntRegion&, void (*)(mozilla::layers::ThebesLayer*, gfxContext*, nsIntRegion const&, mozilla::layers::DrawRegionClip, nsIntRegion const&, void*), void*) [ClientTiledThebesLayer.cpp:5ac8cc2c4064 : 222 + 0x1d]
22:47:39     INFO -       r4 = 0x4680f9cc    r5 = 0xbea26970    r6 = 0xbea26ce0    r7 = 0xbea268ac
22:47:39     INFO -       r8 = 0x41d9825d    r9 = 0x475c46c0   r10 = 0xbea26ce0    fp = 0x00000000
22:47:39     INFO -       sp = 0xbea26848    pc = 0x412835a3
22:47:39     INFO -      Found by: call frame info
22:47:39     INFO -   5  libxul.so!mozilla::layers::ClientTiledThebesLayer::RenderLayer() [ClientTiledThebesLayer.cpp:5ac8cc2c4064 : 391 + 0xb]
22:47:39     INFO -       r4 = 0x4680f800    r5 = 0xbea26908    r6 = 0xbea2695c    r7 = 0x41d9825d
22:47:39     INFO -       r8 = 0x4680f82c    r9 = 0xbea26908   r10 = 0xbea26ce0    fp = 0x00000000
22:47:39     INFO -       sp = 0xbea26900    pc = 0x41284907
22:47:39     INFO -      Found by: call frame info
22:47:39     INFO -   6  libxul.so!mozilla::layers::ClientContainerLayer::RenderLayer() [ClientContainerLayer.h:5ac8cc2c4064 : 61 + 0x5]
22:47:39     INFO -       r4 = 0x00000003    r5 = 0x4680f800    r6 = 0x4680d800    r7 = 0xbea269f8
22:47:39     INFO -       r8 = 0x40256000    r9 = 0x45d10400   r10 = 0x45dfc7e0    fp = 0x00000000
22:47:39     INFO -       sp = 0xbea269e8    pc = 0x41280169
22:47:39     INFO -      Found by: call frame info
22:47:39     INFO -   7  libxul.so!mozilla::layers::ClientContainerLayer::RenderLayer() [ClientContainerLayer.h:5ac8cc2c4064 : 61 + 0x5]

Comment 1

[Sotaro Ikeda [:sotaro]]

I think that CompositorChild::Get() should not be limited only to content process. chrome process also could have CompositorChild.

http://dxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorChild.cpp#95

Comment 2

[Sotaro Ikeda [:sotaro]]

In chrome process, CompositorChild is managed by nsBaseWidget.

http://dxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsBaseWidget.cpp#910

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> In chrome process, CompositorChild is managed by nsBaseWidget.
> 
> http://dxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsBaseWidget.
> cpp#910

On chrome procees, CompositorChild might not be singleton. On content process, CompositorChild is singleton.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> 
> On chrome procees, CompositorChild might not be singleton. On content
> process, CompositorChild is singleton.

It might be better to get CompositorChild via Widget via LayerManager on chrome process.

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> (In reply to Sotaro Ikeda [:sotaro] from comment #2)
> > In chrome process, CompositorChild is managed by nsBaseWidget.
> > 
> > http://dxr.mozilla.org/mozilla-central/source/widget/xpwidgets/nsBaseWidget.
> > cpp#910
> 
> On chrome procees, CompositorChild might not be singleton. On content
> process, CompositorChild is singleton.

I thought CompositorChild::Get() is intended to be only used by content processes, the singleton case.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add GetCompositorChild() to LayerManager

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add GetCompositorChild() to ClientLayerManager

Comment 8

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=86bbc893a28b

Comment 9

[Sotaro Ikeda [:sotaro]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/59b2cfa08365

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59b2cfa08365