Closed Bug 102652 Opened 23 years ago Closed 23 years ago

nsPluginsDirUnix.cpp breaks Qt/Xlib build (any build without GTK?)

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: duraid, Assigned: srgchrpv)

Details

Attachments

(1 file)

the patch
577 bytes, patch
roland.mainz
: review+
waterson
: superreview+
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4+) Gecko/20011001
BuildID:    20011001

On line 127 of modules/plugin/base/src/nsPluginsDirUnix.cpp it says: 

#ifdef MOZ_WIDGET_GTK

#define LOCAL_PLUGIN_DLL_SUFFIX ".so"

It appears that if someone configures mozilla with --without-gtk (for example, I
was trying to build a Qt mozilla) this file won't compile, as
LOCAL_PLUGIN_DLL_SUFFIX won't be defined.

I wonder what the author was thinking when they put that statement inside the
#ifdef MOZ_WIDGET_GTK ?

Workaround is to move the #define LOCAL_PLUGIN_DLL_SUFFIX ".so" up, before that
#ifdef


Reproducible: Always
Steps to Reproduce:
1. Pulled:

26667139 Oct  2 11:55 mozilla-source.tar.bz2
Serge, would you take this? I think this is trivial. And maybe you can answer 
the question. Or was it rhetoric one?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch the patch — — Splinter Review 

    
    

    
  
Xlib toolkit is shot dead, too... same issue... ;-(

I am setting the milestone to 0.9.5 - we should avoid shipping a milestone where
all Unix-ports are unuseable...
Summary: nsPluginsDirUnix.cpp breaks Qt build (any build without GTK?) → nsPluginsDirUnix.cpp breaks Qt/Xlib build (any build without GTK?)
Target Milestone: --- → mozilla0.9.5

    
    

    
  
Comment on attachment 51669 [details] [diff] [review]
the patch

Tested, works... :-)

r=Roland.Mainz@informatik.med.uni-giessen.de

        Attachment #51669 -
        Flags: review+

    
    

    
  
Requesting sr= ...
Keywords: patch, 
          
            review

    
    

    
  
Comment on attachment 51669 [details] [diff] [review]
the patch

sr=waterson

        Attachment #51669 -
        Flags: superreview+

    
    

    
  
checked in
/mozilla/modules/plugin/base/src/nsPluginsDirUnix.cpp,v  <--
new revision: 1.17; previous revision: 1.16

Assignee: av → serge

    
    

    
  
resolved as FIXED
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Taking QA job... I'll verify with my next build (2-3 days)...
QA Contact: shrir → Roland.Mainz

    
    

    
  
Verifying.
Status: RESOLVED → VERIFIED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: