1026562 - Always create ImageBridge when OMTC is enabled on gonk

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

Since Bug 1006957 is enabled, ImageBridge is always used when OMTC is enabled on gonk.

It seems better to change ImageBridge's creation condition as that does not affected by the following preference on gonk.

pref("layers.async-video.enabled", true);
pref("layers.async-video-oop.enabled",true);

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Always create ImageBridge when OMTC is enabled on gonk

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8441453 [details] [diff] [review]
patch - Always create ImageBridge when OMTC is enabled on gonk

Review of attachment 8441453 [details] [diff] [review]:
-----------------------------------------------------------------

Right. At some point we should just remove the pref since OMTC without ImageBridge code is never tested.

Comment 3

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=2d2d307b7dc3

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Nicolas Silva [:nical] from comment #2)
> Comment on attachment 8441453 [details] [diff] [review]
> patch - Always create ImageBridge when OMTC is enabled on gonk
> 
> Review of attachment 8441453 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Right. At some point we should just remove the pref since OMTC without
> ImageBridge code is never tested.

Let's either do it in this bug, or open another one now, and assign to Walter.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Milan Sreckovic [:milan] from comment #4)
> (In reply to Nicolas Silva [:nical] from comment #2)
> > Comment on attachment 8441453 [details] [diff] [review]
> > patch - Always create ImageBridge when OMTC is enabled on gonk
> > 
> > Review of attachment 8441453 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Right. At some point we should just remove the pref since OMTC without
> > ImageBridge code is never tested.
> 
> Let's either do it in this bug, or open another one now, and assign to
> Walter.

This bug can be modified to do it and assign to Walter.

Comment 6

[Walter Litwinczyk [:walter]]

Attachment: omtc_async_video_prefs

Try: https://tbpl.mozilla.org/?tree=Try&rev=620cc56c67f3

Not sure if B2G ICS Emulator Opt test #7 is my fault or not.

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 8443628 [details] [diff] [review]
omtc_async_video_prefs

Review of attachment 8443628 [details] [diff] [review]:
-----------------------------------------------------------------

I would prefer to let these prefs for a little while longer and just ignore them on gonk, as we may still find and need to fix some bugs with AsyncVideo on desktop e10s (and we actually already know about one on windows).

::: dom/ipc/ContentParent.cpp
@@ +1876,5 @@
>          if (useOffMainThreadCompositing) {
>              DebugOnly<bool> opened = PCompositor::Open(this);
>              MOZ_ASSERT(opened);
>  
> +            opened = PImageBridge::Open(this);

There is still an intermittent deadlock letft to fix on Windows with e10s when using ImageBridge (see bug 1009616). So we still need to check this pref on non-gonk platforms (or at least on Windows).

Comment 8

[Walter Litwinczyk [:walter]]

Ok, sorry, I'm a little confused as to what needs to be done for this bug. What more needs to be done on top of the r+ patch? https://bugzilla.mozilla.org/attachment.cgi?id=8441453

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

This is because of the conflicting instructions between comment 5 and comment 7, and some extra information in comment 7 :)

In view of comment 7 and issues on Windows, please land the r+ patch in this bug.  Create a clone of this bug to track the preference removal, and then you can move the second patch to it.  Probably want to make that second patch obsolete in this bug so that it doesn't get landed accidentally.

Comment 10

[Walter Litwinczyk [:walter]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=a65a9ea54613

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6be0bab78c2a

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6be0bab78c2a