1026619 - Add search back to top nav of wm.org

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Michelle Thorne]

The launch of the new wm.org UX is awesome. 

In using the site with some people, I noticed that the search bar is no longer in the top nav. We may want to consider reinstating it, if there's not a strong reason not to, since it's quite valuable to quickly find makes.

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

+1

Comment 2

[Scott [:thecount] Downe]

I just noticed this, and some pages still have the search box.

This feels like a bug and not intended.

Comment 3

[Cassie McDaniel [:cassiemc]]

yes this is a bug, search should be in the main nav, as on https://webmaker.org/tools.

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

* Feel free to move to [july25] -- not a blocker for MP

* Also, Kate: feel free to assign to someone else, if you think that's a good idea

Comment 5

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/868

Comment 6

[Gavin Suntop [:gvn]]

Comment on attachment 8454608 [details] [review]
https://github.com/mozilla/webmaker.org/pull/868

A couple CSS nits on GH.

Also, the behavior of the search icon is weird on some of the sub-pages at smaller window widths where the searchbox isn't present. Maybe this should be a new ticket, I'm not sure. Seems like the behavior was already there, but clicking the icon will make a spinner come up and either eventually go to the search page, or, if you are on the search page already, does nothing. Feels glitchy...

Comment 7

[inactivate account for kate]

Comment on attachment 8454608 [details] [review]
https://github.com/mozilla/webmaker.org/pull/868

https://bugzilla.mozilla.org/show_bug.cgi?id=1037611

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/71b12d497bae0b027756d5f096da667548ad75ad
Fix bug 1026619 - Added search bar to angular pages