Add Attendees table & model to events-service

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jon, Assigned: gvn)

Tracking

Details

(Whiteboard: [events] [june27] [events-rsvp])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
We're adding an Attendees table that both the rsvp and mentor/co-organizers feature will share.

It'll be kinda like:

INTEGER event_id
INTEGER user_id
BOOLEAN didRSVP
BOOLEAN didAttend
BOOLEAN isMentor
BOOLEAN isCoorganizer (better name would be awesome)
(Reporter)

Updated

4 years ago
Whiteboard: [june27][events-mentor][events-rsvp] → [events] [june27] [events-mentor] [events-rsvp]
(Assignee)

Comment 2

4 years ago
Created attachment 8441743 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/27

Note that there's a new field in the Event model too.
Attachment #8441743 - Flags: review?(jon)
(Assignee)

Updated

4 years ago
Blocks: 1003508
(Assignee)

Updated

4 years ago
Blocks: 1003510
(Reporter)

Comment 3

4 years ago
Comment on attachment 8441743 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/27

r- with notes in the PR.

:gvn - Could you create a separate PR with just the content of `models/`? That stuff is nearly ready to go, so we can land that now, and work through the rest of the controllers more easily
Attachment #8441743 - Flags: review?(jon) → review-
(Reporter)

Updated

4 years ago
Attachment #8442377 - Flags: review?(jon) → review+
(Assignee)

Updated

4 years ago
Attachment #8441743 - Flags: review- → review?(jon)
Comment on attachment 8441743 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/27

Overall this looks good, but I was able to rsvp for events that don't exist yet:

repos  curl -XPOST 'http://localhost:1989/rsvp/?eventid=21&userid=3' -H 'Cookie: <cookie>'

Where event 21 isn't a real event.
Attachment #8441743 - Flags: review?(jon)
Attachment #8441743 - Flags: review-
Attachment #8441743 - Flags: review+
(Reporter)

Updated

4 years ago
Whiteboard: [events] [june27] [events-mentor] [events-rsvp] → [events] [june27] [events-rsvp]
(Assignee)

Comment 8

4 years ago
Comment on attachment 8441743 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/27

Ah, good catch! Should be fixed now...
Attachment #8441743 - Flags: review- → review?(cade)

Updated

4 years ago
Attachment #8441743 - Flags: review?(cade) → review+
(Assignee)

Comment 9

4 years ago
Landed on master. Not yet deployed.
(Assignee)

Comment 10

4 years ago
Jbuck, can you do the DB schema migrations? (Or maybe you already did?)
Flags: needinfo?(jon)
(Reporter)

Comment 11

4 years ago
All set on staging, waiting on prod until next week.
Flags: needinfo?(jon)
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.