Closed
Bug 1026698
Opened 10 years ago
Closed 10 years ago
(2.1-visual-refresh)[Ringtones] Add & Set New System Notifications
Categories
(Firefox OS Graveyard :: Gaia::Ringtones, defect)
Tracking
(feature-b2g:2.1)
RESOLVED
FIXED
feature-b2g | 2.1 |
People
(Reporter: padamczyk, Assigned: pivanov)
References
Details
Attachments
(2 files)
Can you please do the following: 1. Add "Firefox_Notify" to the notification selection list in Settings 2. Make "Firefox_Notify" the default notification for the entire device. ie. When notifications come in. When the user takes a screenshot. 3. Remove the current sound for the notification from Gaia (we don't need it) 4. Make "Firefox_Sent" the default sending sound for Email 5. Remove the current sound for sending 6. Make "Firefox_MSG_Sent" the default sending sound for Messages, if you can't then use "Firefox_Sent" instead The files can be found here: https://mozilla.box.com/s/abqt9v8hwuh8uixzo6sq
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → pivanov
Blocks: Ringtones-2.0
Comment 1•10 years ago
|
||
I expect migration is going to be the hard part here. We might be able to punt and say "when you update to Firefox OS 2.0, we'll just reset your ringtone to the factory default". It'd be nice if we could keep user-created ringtones set, but that's hard to detect from a 1.4 install. If we do something like this, make sure to keep me in the loop, since it'll mean we can simplify some mozSettings-compatibility stuff that I added.
Reporter | ||
Comment 2•10 years ago
|
||
We can release the old tones on github. But v.2 is a big release, its like updating from Windows Vista to Windows 7, wallpapers and sound notifications changed.
Updated•10 years ago
|
feature-b2g: --- → 2.1
Reporter | ||
Updated•10 years ago
|
Alias: 2.1-visual-refresh
Summary: (2.0-visual-refresh)[Ringtones] Add & Set New System Notifications → [Ringtones] Add & Set New System Notifications
Reporter | ||
Updated•10 years ago
|
Alias: 2.1-visual-refresh
Summary: [Ringtones] Add & Set New System Notifications → (2.1-visual-refresh)[Ringtones] Add & Set New System Notifications
Reporter | ||
Comment 3•10 years ago
|
||
Pavel, can you please read Comment 1 and try to get these in?
Flags: needinfo?(pivanov)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8470164 -
Flags: feedback?(padamczyk)
Flags: needinfo?(pivanov)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8470164 [details] [review] patch for Gaia/master Great, it works.
Attachment #8470164 -
Flags: feedback?(padamczyk) → feedback+
Assignee | ||
Updated•10 years ago
|
Attachment #8470164 -
Flags: review?(squibblyflabbetydoo)
Comment 6•10 years ago
|
||
Comment on attachment 8470164 [details] [review] patch for Gaia/master This looks good, except for one comment I have on Github, so r=me with that addressed. Note that I haven't tried this patch out, and I have no idea if these are the right sounds to use. I assume Patryk's f+ means the right sounds are being used in the right spots. :)
Attachment #8470164 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Thanks :) can I merge it now?
Flags: needinfo?(squibblyflabbetydoo)
Comment 8•10 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #7) > Thanks :) > > can I merge it now? Well, you'll need to add notifier_firefox_notify.opus to replace the .ogg version first. And do please remember to create the Opus file from a lossless version of notifier_firefox_notify. :) Patryk might be able to help with that if you don't have the lossless version.
Flags: needinfo?(squibblyflabbetydoo)
Reporter | ||
Comment 10•10 years ago
|
||
Hey Pavel, its already attached to the bug: FX Notifiers.zip. As an FYI all future sounds will be OPUS.
Flags: needinfo?(padamczyk) → needinfo?(pivanov)
Assignee | ||
Comment 11•10 years ago
|
||
oh ... yeah ... i renamed it on notifier_firefox.opus sorry Hey Jim, the file is there and the name is notifier_firefox.opus I fixed the test with this file, thanks :)
Flags: needinfo?(pivanov) → needinfo?(squibblyflabbetydoo)
Comment 12•10 years ago
|
||
Ok, I added a couple of new notes to GitHub. If you could fix those, that would be great. Thanks!
Flags: needinfo?(squibblyflabbetydoo)
Assignee | ||
Comment 13•10 years ago
|
||
Hey Jim, can you check it one more time? Thanks in advance :)
Flags: needinfo?(squibblyflabbetydoo)
Comment 14•10 years ago
|
||
Everything looks good now. Land whenever you're ready! (Note that I haven't tested the individual apps, but I *have* tested that the audio files are correct.)
Flags: needinfo?(squibblyflabbetydoo)
Assignee | ||
Comment 15•10 years ago
|
||
Thanks :) I made some tests and everything looks good :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/70f3935608c9e21461db8f60c50ae1be78a4460c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 16•10 years ago
|
||
this pull break gaia build unit test
Comment 17•10 years ago
|
||
I will send a pull request to fix it.
Comment 18•10 years ago
|
||
merged. https://github.com/mozilla-b2g/gaia/commit/193e46e885a53adefd0346725b3fc9b13e2dacae
You need to log in
before you can comment on or make changes to this bug.
Description
•