(2.1-visual-refresh)[Ringtones] Add & Set New System Notifications

RESOLVED FIXED

Status

Firefox OS
Gaia::Ringtones
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: patryk, Assigned: ivanovpavel)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(feature-b2g:2.1)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Can you please do the following:
1. Add "Firefox_Notify" to the notification selection list in Settings
2. Make "Firefox_Notify" the default notification for the entire device. ie. When notifications come in. When the user takes a screenshot.
3. Remove the current sound for the notification from Gaia (we don't need it)
4. Make "Firefox_Sent" the default sending sound for Email
5. Remove the current sound for sending
6. Make "Firefox_MSG_Sent" the default sending sound for Messages, if you can't then use "Firefox_Sent" instead

The files can be found here:
https://mozilla.box.com/s/abqt9v8hwuh8uixzo6sq
(Reporter)

Updated

4 years ago
Assignee: nobody → pivanov
Blocks: 1014009

Comment 1

4 years ago
I expect migration is going to be the hard part here. We might be able to punt and say "when you update to Firefox OS 2.0, we'll just reset your ringtone to the factory default". It'd be nice if we could keep user-created ringtones set, but that's hard to detect from a 1.4 install.

If we do something like this, make sure to keep me in the loop, since it'll mean we can simplify some mozSettings-compatibility stuff that I added.
(Reporter)

Comment 2

4 years ago
We can release the old tones on github. But v.2 is a big release, its like updating from Windows Vista to Windows 7, wallpapers and sound notifications changed.

Updated

4 years ago
feature-b2g: --- → 2.1
(Reporter)

Updated

4 years ago
Alias: 2.1-visual-refresh
Blocks: 1046324
No longer blocks: 1014009
Summary: (2.0-visual-refresh)[Ringtones] Add & Set New System Notifications → [Ringtones] Add & Set New System Notifications
(Reporter)

Updated

4 years ago
Alias: 2.1-visual-refresh
Summary: [Ringtones] Add & Set New System Notifications → (2.1-visual-refresh)[Ringtones] Add & Set New System Notifications
(Reporter)

Comment 3

4 years ago
Created attachment 8469507 [details]
fx_notifiers.zip

Pavel, can you please read Comment 1 and try to get these in?
Flags: needinfo?(pivanov)
Created attachment 8470164 [details] [review]
patch for Gaia/master
Attachment #8470164 - Flags: feedback?(padamczyk)
Flags: needinfo?(pivanov)
(Reporter)

Comment 5

4 years ago
Comment on attachment 8470164 [details] [review]
patch for Gaia/master

Great, it works.
Attachment #8470164 - Flags: feedback?(padamczyk) → feedback+
Attachment #8470164 - Flags: review?(squibblyflabbetydoo)

Comment 6

4 years ago
Comment on attachment 8470164 [details] [review]
patch for Gaia/master

This looks good, except for one comment I have on Github, so r=me with that addressed.

Note that I haven't tried this patch out, and I have no idea if these are the right sounds to use. I assume Patryk's f+ means the right sounds are being used in the right spots. :)
Attachment #8470164 - Flags: review?(squibblyflabbetydoo) → review+
Thanks :) 

can I merge it now?
Flags: needinfo?(squibblyflabbetydoo)

Comment 8

4 years ago
(In reply to Pavel Ivanov [:ivanovpavel] from comment #7)
> Thanks :) 
> 
> can I merge it now?

Well, you'll need to add notifier_firefox_notify.opus to replace the .ogg version first. And do please remember to create the Opus file from a lossless version of notifier_firefox_notify. :) Patryk might be able to help with that if you don't have the lossless version.
Flags: needinfo?(squibblyflabbetydoo)
Hey Patryk,
can you help?
Flags: needinfo?(padamczyk)
(Reporter)

Comment 10

4 years ago
Hey Pavel, its already attached to the bug: FX Notifiers.zip.
As an FYI all future sounds will be OPUS.
Flags: needinfo?(padamczyk) → needinfo?(pivanov)
oh ... yeah ... i renamed it on notifier_firefox.opus sorry

Hey Jim,
the file is there and the name is notifier_firefox.opus I fixed the test with this file, thanks :)
Flags: needinfo?(pivanov) → needinfo?(squibblyflabbetydoo)

Comment 12

4 years ago
Ok, I added a couple of new notes to GitHub. If you could fix those, that would be great. Thanks!
Flags: needinfo?(squibblyflabbetydoo)
Hey Jim,
can you check it one more time? 

Thanks in advance :)
Flags: needinfo?(squibblyflabbetydoo)

Comment 14

4 years ago
Everything looks good now. Land whenever you're ready! (Note that I haven't tested the individual apps, but I *have* tested that the audio files are correct.)
Flags: needinfo?(squibblyflabbetydoo)
Thanks :)

I made some tests and everything looks good :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/70f3935608c9e21461db8f60c50ae1be78a4460c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
this pull break gaia build unit test
I will send a pull request to fix it.
You need to log in before you can comment on or make changes to this bug.