Support batch requests in webmaker-user-client

RESOLVED FIXED

Status

Webmaker
Login
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jbuck, Assigned: cade)

Tracking

Details

(Whiteboard: [events-mentor] [june27] [events])

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
webmaker-user-client should support batch get requests for users by user id, username, and email address.
(Reporter)

Updated

3 years ago
Component: Events → Login
(Assignee)

Comment 1

3 years ago
Created attachment 8441645 [details] [review]
https://github.com/mozilla/webmaker-user-client/pull/3
Attachment #8441645 - Flags: review?(jon)
(Assignee)

Comment 2

3 years ago
Created attachment 8441647 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/279
Attachment #8441647 - Flags: review?(jon)
(Reporter)

Updated

3 years ago
Attachment #8441645 - Flags: review?(jon) → review+
(Reporter)

Updated

3 years ago
Attachment #8441647 - Flags: review?(jon) → review-
(Assignee)

Comment 3

3 years ago
Comment on attachment 8441647 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/279

does https://github.com/mozilla/login.webmaker.org/pull/279#discussion_r13913892 fix up any confusion? I can add some comments to clarify that filter callback
Attachment #8441647 - Flags: review- → review?(jon)
(Reporter)

Updated

3 years ago
Attachment #8441647 - Flags: review?(jon) → review+

Comment 4

3 years ago
Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/1fe44c2d21db8958871a686525cdcb2c4d6edb9d
Bug 1026701 - Add batched user request routes for webmaker-user-client
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Docs please
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

3 years ago
Created attachment 8442412 [details] [review]
https://github.com/mozilla/webmaker-user-client/pull/4

Docs for batch user reqs
Attachment #8442412 - Flags: review?(kate)
Attachment #8442412 - Flags: review?(kate) → review+
(Assignee)

Comment 7

3 years ago
merged: https://github.com/mozilla/webmaker-user-client/commit/9cfb11dfd4b5e0d1d83854fa36ca43787258f4d6
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.