1026704 - Switch GStreamer and FMP4 preference order in DecoderTraits::InstantiateDecoder() and DecoderTraits::CreateReader()

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Corentin Cos]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140506152807

Steps to reproduce:

FMP4 is intended to be used instead of GStreamer in the future. So far, if on a certain platform, both tools work, GStreamer is used by default. Switching FMP4's and GStream's case order in DecoderTraits::InstantiateDecoder() and DecoderTraits::CreateReader() will have FMP4 used by default if both tools work.
This case switching has to be done for the bug 1016413 for instance.

Comment 1

[Corentin Cos]

Attachment: bug 1026704: switching GStreamer's and FMP4's cases in DecoderTraits::InstantiateDecoder() and DecoderTraits::CreateReader()

Comment 2

[Corentin Cos]

Attachment: bug 1026704: switching GStreamer's and FMP4's cases in DecoderTraits::InstantiateDecoder() and DecoderTraits::CreateReader()

Sorry for the spam - improvement in the commit message.

Comment 3

[Corentin Cos]

To complete the description, this only concerns Linux based platforms, because GStreamer is used on these only.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8441622 [details] [diff] [review]
bug 1026704: switching GStreamer's and FMP4's cases in DecoderTraits::InstantiateDecoder() and DecoderTraits::CreateReader()

Review of attachment 8441622 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look fine. Thanks for splitting the patch.

The first line of the commit message should fit on one line though. Please update the patch with a shorter first line, something like:

Bug 1026704 - Prefer MP4Reader over GStreamer. r=rillian

When you upload the new version, you can say 'carrying forward r=rillian' in the comment and mark the bug 'checkin-needed'.

Comment 5

[Corentin Cos]

Attachment: carrying forward r=rillian

Comment 6

[Corentin Cos]

Attachment: Bug 1026704: switching GStreamer's and FMP4's cases in DecoderTraits::InstantiateDecoder() and DecoderTraits::CreateReader()

carrying forward r=rillian

Comment 7

[Carsten Book [:Tomcat]]

Hi, would it be possible to paste a try link here (also https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices might be useful)

Comment 8

[Corentin Cos]

Pushed to Try : https://tbpl.mozilla.org/?tree=Try&rev=11e6ac5cc98b

Comment 9

[Ralph Giles (:rillian)]

Green on try.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e047743374c4

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e047743374c4