Closed
Bug 1026714
Opened 10 years ago
Closed 6 years ago
Don't mark nodes in the shadow tree as orphan nodes
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: khuey, Assigned: smaug)
References
Details
Attachments
(1 file, 1 obsolete file)
|
911 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8441629 -
Flags: review?(wchen)
|
||
Comment 1•10 years ago
|
||
A node may be in a shadow tree but might not get rendered (when the shadow tree does not have a host in the document) in which case I think it would be considered an orphan in the context of this code. If that is closer to the definition of "orphan" here, then it would be better to replace tmp->IsInDoc() with tmp->GetCrossShadowCurrentDoc() (there currently isn't a CrossShadowIsInDoc() method).
|
|
||
Updated•10 years ago
|
Attachment #8441629 -
Flags: review?(wchen)
|
Reporter | |
Updated•8 years ago
|
Assignee: khuey → wchen
|
||
Updated•7 years ago
|
|
Assignee | |
Comment 2•6 years ago
|
||
Assignee: nobody → bugs
Attachment #8441629 -
Attachment is obsolete: true
Attachment #8947868 -
Flags: review?(continuation)
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8947868 [details] [diff] [review] shadow_orphan.diff Review of attachment 8947868 [details] [diff] [review]: ----------------------------------------------------------------- I don't have any idea what this is supposed to do, sorry. Maybe somebody who knows what composed or uncomposed docs are could review this...
Attachment #8947868 -
Flags: review?(continuation)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8947868 -
Flags: review?(mrbkap)
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8947868 [details] [diff] [review] shadow_orphan.diff Yeah, this looks right to me.
Attachment #8947868 -
Flags: review?(mrbkap) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e1daef0276f6 Don't mark nodes in the shadow tree as orphan nodes , r=mrbkap
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e1daef0276f6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•