1026718 - Make VolatileBuffer not use MOZ_DECLARE_REFCOUNTED_TYPENAME

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[(no longer active)]

The issue here is that mozalloc is not part of libxul, so
MOZ_DECLARE_REFCOUNTED_TYPENAME expands to nothing there.  MSVC seems
to just happily inline these function calls even though they are on a
dllimport class.

Comment 1

[(no longer active)]

Attachment: Make VolatileBuffer not use MOZ_DECLARE_REFCOUNTED_TYPENAME

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8441631 [details] [diff] [review]
Make VolatileBuffer not use MOZ_DECLARE_REFCOUNTED_TYPENAME

Review of attachment 8441631 [details] [diff] [review]:
-----------------------------------------------------------------

I'd rather change MOZ_DECLARE_REFCOUNTED_TYPENAME to expand independently of MOZILLA_INTERNAL_API.

Comment 3

[(no longer active)]

Attachment: Expand MOZ_DECLARE_REFCOUNTED_TYPENAME unconditioanlly in order to make it available outside of libxul as well; r=glandium

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8442053 [details] [diff] [review]
Expand MOZ_DECLARE_REFCOUNTED_TYPENAME unconditioanlly in order to make it available outside of libxul as well; r=glandium

Review of attachment 8442053 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/RefPtr.h
@@ +166,5 @@
> +// two small inline functions which will hopefully get eliminated by the linker
> +// in non-leak-checking builds.
> +#define MOZ_DECLARE_REFCOUNTED_TYPENAME(T) \
> +  const char* typeName() const { return #T; } \
> +  size_t typeSize() const { return sizeof(*this); }

I think you can reasonably put that under #if defined(DEBUG) || defined(FORCE_BUILD_REFCNT_LOGGING)

That said, I'm not a MFBT peer.

Comment 5

[(no longer active)]

(In reply to Mike Hommey [:glandium] from comment #4)
> Comment on attachment 8442053 [details] [diff] [review]
> Expand MOZ_DECLARE_REFCOUNTED_TYPENAME unconditioanlly in order to make it
> available outside of libxul as well; r=glandium
> 
> Review of attachment 8442053 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mfbt/RefPtr.h
> @@ +166,5 @@
> > +// two small inline functions which will hopefully get eliminated by the linker
> > +// in non-leak-checking builds.
> > +#define MOZ_DECLARE_REFCOUNTED_TYPENAME(T) \
> > +  const char* typeName() const { return #T; } \
> > +  size_t typeSize() const { return sizeof(*this); }
> 
> I think you can reasonably put that under #if defined(DEBUG) ||
> defined(FORCE_BUILD_REFCNT_LOGGING)

Sure, I could do that.  Shouldn't make a difference either way...

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 8442053 [details] [diff] [review]
Expand MOZ_DECLARE_REFCOUNTED_TYPENAME unconditioanlly in order to make it available outside of libxul as well; r=glandium

Review of attachment 8442053 [details] [diff] [review]:
-----------------------------------------------------------------

Actually you are, per very ancient discussion from ~2012ish (?) that only made its way into the module page list just recently.  :-)

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8eeb287c59fd

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8eeb287c59fd