1026768 - Pass the restyle hint through from ProcessOneRestyle to ComputeStyleChangeFor rather than converting it to a boolean and back

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This was originally bug 996796 patch 6, but it's also needed bug 931668,
so I'm moving it into its own bug.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Pass the restyle hint through from ProcessOneRestyle to ComputeStyleChangeFor rather than converting it to a boolean and back

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8441693 [details] [diff] [review]
Pass the restyle hint through from ProcessOneRestyle to ComputeStyleChangeFor rather than converting it to a boolean and back

Review of attachment 8441693 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: layout/base/RestyleManager.cpp
@@ +2970,5 @@
>                                 aMinChange, aRestyleTracker,
>                                 treeMatchContext,
>                                 visibleKidsOfHiddenElement);
>  
> +      restyler.Restyle(aRestyleHint);

I assume by this point eRestyle_LaterSiblings will never be in aRestyleHint, since RestyleTracker::ProcessOneRestyle is asserting this?  Can you add some assertions in ElementRestyler::Restyle{,Self} as they check aRestyleHint in ways that assume that flag isn't in there, and which currently we ensure by checking the bool and only passing in eRestyle_Self/Subtree/0.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=fbaab9aa48aa

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bdf18e88d834

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bdf18e88d834