Closed Bug 1026778 Opened 6 years ago Closed 6 years ago

Add test for smart collection pinning

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [p=3],[systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
amirn
: review+
ranbena
: review+
Details | Review
No description provided.
Attached file Github pull request
Work in progress...
Comment on attachment 8441755 [details] [review]
Github pull request

Ran, Amir - wondering if you guys could give this one a review. It's a test and not part of the build, so we don't need to be 100% accurate and syntax correct. This is more-so to inform you guys of what I'm doing and answer any questions you might have about the integration testing framework.

I think we're in a unique position where we can have really well tested functionality. Let me know what you think!
Attachment #8441755 - Flags: review?(ran)
Attachment #8441755 - Flags: review?(amirn)
Comment on attachment 8441755 [details] [review]
Github pull request

looks great. thanks!
Attachment #8441755 - Flags: review?(amirn) → review+
Comment on attachment 8441755 [details] [review]
Github pull request

Code looks good. Didn't run it.
Attachment #8441755 - Flags: review?(ran) → review+
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Landed: https://github.com/mozilla-b2g/gaia/commit/dd94cbaa02cff9479edd163d122c02ed422872eb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8441755 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've done our best effort at testing this and believe it is safe for uplift.
Attachment #8441755 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8441755 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
You need to log in before you can comment on or make changes to this bug.