Closed Bug 1026811 Opened 7 years ago Closed 7 years ago
Upgrade to Code
Mirror 4 .2
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8442045 - Flags: review?(rcampbell)
Hrm, there is a test failing because there is no callback parameter to term.showType() any more. Looking at the code, I'm wondering if this is an undocumented patch on top of the library: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/sourceeditor/codemirror/tern.js#224. Just looking at a random commit from 2013 on CodeMirror I never see this "c" parameter to the function. Once Bug 1026560 lands we can actually emit the show-information event inside of the typeTip callback instead of having a patched version of the tern.js file
I've filed https://github.com/marijnh/CodeMirror/pull/2644 on the CodeMirror project to see if we can port this customization back into the project to avoid patching in the future.
Same patch, but with PR from Comment 4 applied: https://tbpl.mozilla.org/?tree=Try&rev=5dca837e59a0
Comment on attachment 8442810 [details] [diff] [review] codemirror-4.2.patch Review of attachment 8442810 [details] [diff] [review]: ----------------------------------------------------------------- this looks fine to me. r+ with a successful try run.
Attachment #8442810 - Flags: review?(rcampbell) → review+
The custom changes in tern.js have now been merged into CodeMirror so we won't need to port them over next time: https://github.com/marijnh/CodeMirror/pull/2644
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.