1026814 - Arabic language selection pushes icons off of vertical homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Stephany Wilkes]

Before you attempt to repro, be aware that you may not be able to recover from this bug and may need to re-flash your phone to get out of this state. Restarting doesn't work because the language setting holds. 

In the latest 2.0 build:
* Select Arabic language on set-up/FTE or change to Arabic in language settings.

* Observe Homescreen icons shift right, leaving one vertical row of icons aligned right. If the user selected Arabic in FTE, this is all s/he will ever see of the Homescreen (they won't necessarily know anything is wrong or why).

* Note that the Settings icon may not be visible/included in the single vertical row. If the Settings icon is not there, there is no way (since pinch-to-zoom has been taken out) for the user to access the Settings icon in order to be able to click on it and change the language setting to recover the full homescreen (which a normal user would not know to do anyway).

Until we have RTL support, we should not include languages in FTE that users can choose, that will result in this outcome. 

Believe this should block since it renders the device unusable. It's very easy to hit Arabic accidentally (it's in the top-most section of the list) if you're rapidly clicking through to be done with FTE.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

fyi

Comment 2

[Johan Lorenzo [:jlorenzo]]

Can we remove RTL languages for our 2.0 builds?

Comment 3

[Jason Smith [:jsmith]]

I don't think we should block on this. Trying to support RTL in the vertical homescreen at this point would be way too much work.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #3)
> I don't think we should block on this. Trying to support RTL in the vertical
> homescreen at this point would be way too much work.

Or should say - it's not in scope for 2.0 release.

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

I think the issue here isn't that that we're not going to support Arabic. 

As Stephany says, the issue "renders the device unusable. It's very easy to hit Arabic accidentally (it's in the top-most section of the list) if you're rapidly clicking through to be done with FTE." If a user accidentally hits Arabic during FTE, then he won't be able to revert and switch back to another language (at least, that's what I understand)

Comment 6

[Kevin Grandon :kgrandon]

I am not sure if we can support RTL, but we should certainly make sure it doesn't break things. Taking this.

Comment 7

[Kevin Grandon :kgrandon]

Attachment: Github pull request

If someone has time to fix this after all of the blockers, we can revisit it, but for now we should disable RTL support I think until it's working.

Cristian - do you have time for a review?

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8441840 [details] [review]
Github pull request

LGTM, go ahead

Comment 9

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/4022917d440fa2ec479aedf99e34494cb4b43a86

Comment 10

[Axel Hecht [:Pike]]

Removing languages from the builds is going to throw us back ages on those localizations, we should not do that.

Also, please only use [e-mail] for l10n work, I don't want to get all this bugmail twice.

I'd suggest that once we get this verified, we should request uplift to 2.0.

Also, there's a pseudo localization, qps-plocm (Mirrored English), please make sure to test-drive at least basic functionality when changing gaia.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8441840 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've done our best effort at testing this and believe it is safe for uplift.

Comment 12

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/8f661e09ee996b598c38768222465009f2737b52

Comment 13

[Martin Shuman [:Marty]]

Verified Fixed. Issue no longer occurs in Flame 2.1 or 2.0
All icons are visible and usable on Homescreen when using Arabic Language selection.

Environmental Variables:
Device: Flame 2.1
BuildID: 20140915000203
Gaia: 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: 7546fedad918
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0
BuildID: 20140915000202
Gaia: 7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko: 13e04ab68621
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0