Support file:// in places module queries

RESOLVED INCOMPLETE

Status

P2
enhancement
RESOLVED INCOMPLETE
4 years ago
11 months ago

People

(Reporter: brettz9, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good next bug] [lang=js])

(Reporter)

Description

4 years ago
I'd like it to be possible to query the bookmarks or history with a url of "file:*" or such. The module sdk/places/utils includes a "urlQueryParser" function which tests against https? but not file:. If the regex is changed to "/^(?:https?|file):\/\//" I believe everything will work.

If bug 885616 is intended for making queries as well as saving them, since query URIs include support for uriIsPrefix, this bug may be a dupe. However, if that bug will take a long time, or if this is not the case, I'd appreciate what I think should be an easy fix.

Thanks!
(Reporter)

Comment 1

4 years ago
I see that supplying a value of "*." may get a similar result to that intended, but I'm not sure that is so intuitive since it apparently will exclude /^https?/ which I think people might expect from "*.".

Updated

4 years ago
Priority: -- → P2
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: [good first bug] [lang=javascript]
Blocks: 888483
Whiteboard: [good first bug] [lang=javascript] → [good next bug] [lang=javascript]

Updated

2 years ago
Whiteboard: [good next bug] [lang=javascript] → [good next bug] [lang=js]
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: UNCONFIRMED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.