1026836 - FxAccounts doesn't react correctly to mismatched version string in credentials storage.

Status: NEW

(Firefox :: Firefox Accounts, defect, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

See http://hg.mozilla.org/mozilla-central/annotate/6ee2566596f8/services/fxaccounts/FxAccounts.jsm#l108 - the code declines to cache the value if the version is mis-matched, but still returns the data with the incorrect version string.  I think the intent there was to return null to indicate no user is logged in, but the code doesn't actually do that.

We need to clarify what semantics we want and write tests to ensure they are enforced.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

This is still relevant, although not urgent as we are still on version 1 and have no plans to upgrade at this stage - so p3.