Closed
Bug 1026903
Opened 10 years ago
Closed 10 years ago
make nsStyleContext protected members private
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
381 bytes,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
I don't think there's any good reason for the protected members on nsStyleContext not to be private. Making them private might make the compiler's inlining choices a bit better (if we're not doing LTO).
Attachment #8441868 -
Flags: review?(dbaron)
Attachment #8441868 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa47f05a4ef9
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fa47f05a4ef9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•