Closed
Bug 1027074
Opened 10 years ago
Closed 10 years ago
MOZ_CRASHREPORTER_NO_REPORT is defined in both ttest.py and PerfConfigurator.py
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
1.37 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Broken out from bug 1026970. MOZ_CRASHREPORTER_NO_REPORT is defined in two places: https://hg.mozilla.org/build/talos/file/9dd42f136266/talos/ttest.py#l274 and https://hg.mozilla.org/build/talos/file/9dd42f136266/talos/PerfConfigurator.py#l216 Bug 1026970 comment 3 says that the former is a superset of the latter, so the latter must be redundant & can be removed.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8442090 -
Flags: review?(jmaher)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8442090 [details] [diff] [review] Remove MOZ_CRASHREPORTER_NO_REPORT define, since it's already set in ttest.py Review of attachment 8442090 [details] [diff] [review]: ----------------------------------------------------------------- thanks for the cleanup, you are well on your way to being a talos expert!
Attachment #8442090 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #2) > thanks for the cleanup, you are well on your way to being a talos expert! Not quite so fast there Mr Maher! You'll not hoodwink me that easily... ;-) remote: https://hg.mozilla.org/build/talos/rev/82e436057c53
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•