MOZ_CRASHREPORTER_NO_REPORT is defined in both ttest.py and PerfConfigurator.py

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Broken out from bug 1026970.

MOZ_CRASHREPORTER_NO_REPORT is defined in two places:
https://hg.mozilla.org/build/talos/file/9dd42f136266/talos/ttest.py#l274
and
https://hg.mozilla.org/build/talos/file/9dd42f136266/talos/PerfConfigurator.py#l216

Bug 1026970 comment 3 says that the former is a superset of the latter, so the latter must be redundant & can be removed.
Comment on attachment 8442090 [details] [diff] [review]
Remove MOZ_CRASHREPORTER_NO_REPORT define, since it's already set in ttest.py

Review of attachment 8442090 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the cleanup, you are well on your way to being a talos expert!
Attachment #8442090 - Flags: review?(jmaher) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Joel Maher (:jmaher) from comment #2)
> thanks for the cleanup, you are well on your way to being a talos expert!

Not quite so fast there Mr Maher! You'll not hoodwink me that easily... ;-)

remote:   https://hg.mozilla.org/build/talos/rev/82e436057c53
Depends on: 1028999
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.