Closed Bug 1027112 Opened 10 years ago Closed 10 years ago

[Homescreen] New wallpaper to replace current grass wallpaper

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: amylee, Assigned: pivanov)

Details

Attachments

(7 files, 3 obsolete files)

Attached file PH_Tree_Wallpaper.zip (obsolete) —
Hi, 

Attached is zip folder of a new wallpaper (PH_Tree_Wallpaper) to replace one of the current wallpapers (see screenshot).

Thanks!
Attached image 2014-06-18-10-46-21.png
Please replace this one currently in the OS.
Attached file patch for Gaia/master
Attachment #8442486 - Flags: ui-review?(amlee)
Comment on attachment 8442486 [details] [review]
patch for Gaia/master

Hi Pavel, 

When I flashed the patch I'm still seeing the old wallpaper and not the new one.
Attachment #8442486 - Flags: ui-review?(amlee) → ui-review-
Hey Amy,
I just find that 2 of the images have some problems ... PH_Tree@1.5x.jpg and PH_Tree@2x.jpg I can't open them in Photoshop neither in browser ... Could not complete your request because an unknown or invalid JPEG marker type is found. Can you give me these 2 images one more time ... Thanks :) (I have a device now ... so I can test better now :)
Attached image PH_Tree_540x960.jpg (obsolete) —
Here are the wallpapers
Attached image PH_Tree_480x854.jpg (obsolete) —
Here are the wallpapers
Attachment #8442486 - Flags: ui-review- → ui-review?(amlee)
Hey Pavel, 

Can you please replace the wallpapers with these ones? Thanks
Attachment #8442141 - Attachment is obsolete: true
Attachment #8442486 - Flags: ui-review?(amlee) → ui-review-
Attachment #8442486 - Flags: ui-review- → ui-review?(amlee)
Attached image Tree_Wallpaper_Spec.png
Hi Pavel, 

It looks like the wallpaper isn't being cropped properly. It looks like it's being enlarged. See attached. 

Also, I noticed that the PH_Tree_480x854.png file I last attached might have been corrupted so I'm going to attach it again. Thanks!
Attachment #8442486 - Flags: ui-review?(amlee) → ui-review-
Attached image PH_Tree_480x854_v2.jpg
Attachment #8442972 - Attachment is obsolete: true
Attachment #8442973 - Attachment is obsolete: true
Attachment #8442486 - Flags: ui-review- → ui-review?(amlee)
Comment on attachment 8442486 [details] [review]
patch for Gaia/master

Still seeing the image being enlarged when selected as a wallpaper.
Attachment #8442486 - Flags: ui-review?(amlee) → ui-review-
Attachment #8442486 - Flags: ui-review- → ui-review?(amlee)
Attachment #8442486 - Flags: review?(21)
Flags: needinfo?(21)
Comment on attachment 8442486 [details] [review]
patch for Gaia/master

Looks great! Thanks
Attachment #8442486 - Flags: ui-review?(amlee) → ui-review+
Attachment #8442486 - Flags: review?(21) → review+
Flags: needinfo?(21)
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/eabe7bbede63e0d3aaff083b566833ecfd25b6ac
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
I inadvertently included some extra minor css changes in that re-landing. Normally I would leave as-is, but to avoid any mis-blames in case of backout, I'm going to fix it. Sorry for the extra noise on this.

Here is the properly landed commit: https://github.com/mozilla-b2g/gaia/commit/be45eb0d3abd52725ab139ad7ceb4fc9928a8995
Please nominate for uplift if you think this should go into 2.0.
No longer blocks: vertical-home-next
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: