1027188 - App Manager validation warns to at least provide a 128px icon when a 256px icon exists

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[:Harald Kirschner :digitarald]

When using a manifest with only a 256px icon a warning is shown:

"app submission to the Marketplace needs at least a 128px icon"

Comment 1

[Paul Rouget [:paul]]

(In reply to Harald Kirschner :digitarald from comment #0)
> When using a manifest with only a 256px icon a warning is shown:
> 
> "app submission to the Marketplace needs at least a 128px icon"

Does the marketplace accept bigger icons? If so, there should be no message.
Does the marketplace only accept 128px icons? If so, the message should not say "at least".

Comment 2

[Andrew Williamson [:eviljeff]]

"app submission to the Marketplace needs at least a 128px icon" means
"app submission to the Marketplace needs an icon that is 128px, but can have others" rather than
"app submission to the Marketplace needs an icon, of a size at least 128px"

suggestions for the revised message?

Comment 3

[Paul Rouget [:paul]]

What does the marketplace need exactly?

An icon of 128px and any other size, or an icon of a size at least 128px?

Comment 4

[Andrew Williamson [:eviljeff]]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #3)
> What does the marketplace need exactly?
> 
> An icon of 128px and any other size, or an icon of a size at least 128px?

It only needs an icon that is exactly 128px x 128px.

Comment 5

[Paul Rouget [:paul]]

So the message should be: "app submission to the Marketplace needs a 128px icon"

Comment 6

[Paul Rouget [:paul]]

Attachment: v1

Comment 7

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/27fa9c3d9702

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27fa9c3d9702