1027371 - [1.4] Uplift gallery thumbnail locator changes to 1.4 from master

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Dylan Chun Wong [:dwong]]

A recent commit uplifted to the 1.4 branch changed gallery thumbnails from li's to div's and so automated tests were failing due to the locator:

Commit: https://github.com/mozilla-b2g/gaia/commit/c6ec00c1981eb4a03927ed70657d9541f3144cfb#diff-9feaae5716dcf1b57e0a11a426488733L20

Failed Tests: http://selenium.qa.mtv2.mozilla.com:8080/view/B2G/job/b2g.flame.mozilla-b2g30_v1_4.ui.non-smoketest/36/HTML_Report/

Log for one test: 
Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
testMethod()
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_add_photo_to_contact.py", line 45, in test_add_photo_from_gallery_to_contact
gallery.wait_for_thumbnails_to_load()
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/tests/python/gaia-ui-tests/gaiatest/apps/gallery/app.py", line 36, in wait_for_thumbnails_to_load
self.wait_for_element_displayed(*self._gallery_items_locator)
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 42, in wait_for_element_displayed
lambda m: m.find_element(by, locator).is_displayed())
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until
cause=last_exc)
TimeoutException: Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 122, in until
rv = condition(self.marionette)
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 42, in <lambda>
lambda m: m.find_element(by, locator).is_displayed())
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette.py", line 1189, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette.py", line 613, in _send_message
self._handle_error(response)
File "/var/jenkins/workspace/b2g.flame.mozilla-b2g30_v1_4.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette.py", line 634, in _handle_error
raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
TimeoutException: Timed out after 30.1335370541 seconds, caused by <class 'marionette.errors.NoSuchElementException'>

Comment 1

[Dylan Chun Wong [:dwong]]

Attachment: Update to locator to match the new tag for thumbnails

Comment 2

[Dylan Chun Wong [:dwong]]

This bug and pr are to uplift commit 308cf91dac2f3fda7d10c2895aa92be9979c9b52 to 1.4.

Comment 3

[Zac C (:zac)]

Uplifted:
https://github.com/mozilla-b2g/gaia/commit/510792f5bdc04ae11b4cec89ed468f2a5bcfbf2d

Thanks Dylan and Kate.