Closed
Bug 1027372
Opened 9 years ago
Closed 9 years ago
runNetworkTests break steeplechase tests
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: drno, Assigned: drno)
Details
Attachments
(1 file, 1 obsolete file)
1.98 KB,
patch
|
Details | Diff | Splinter Review |
With the use of runNetworkTest() steeplechase test execution fails, because info() is missing.
Assignee | ||
Comment 1•9 years ago
|
||
Added a wrapper around info() which first checks if that function is available. Try run: https://tbpl.mozilla.org/?tree=Try&rev=9330138aebcf
Attachment #8442490 -
Flags: review?(gmealer)
Comment on attachment 8442490 [details] [diff] [review] bug_1027372_fix_info.patch Review of attachment 8442490 [details] [diff] [review]: ----------------------------------------------------------------- Would prefer safeInfo() over infoSafe(), along with a function comment explaining why the wrapper's there. However, r+ either way.
Attachment #8442490 -
Flags: review?(gmealer) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Updated according to geo's feedback. Carrying forward r+=geo
Attachment #8442490 -
Attachment is obsolete: true
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b965d005fb3
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3b965d005fb3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•