Closed Bug 1027424 Opened 8 years ago Closed 8 years ago
Scratchpad Inspect should show non-objects in inspector, not comments
Screenshot showing the Object Inspector (top) for a function, and a proposed output box for primitives (bottom) occupying the same panel. Ideally the panel would have a header stating what we’re inspecting or outputting. So in those two examples we would have: - "function test()" (same styling as the console) - "string" (instead of "Output" in my mock-up)
I argued for removing display and only having inspect, but robcee was against it. I forget his reasoning why. I'm still for it, and I think we could kill two birds with one stone here...
Status: UNCONFIRMED → NEW
Ever confirmed: true
To be honest I like using the Display shortcut for quick inspection and the Inspect shortcut for more involved ones. And fixing the inconsistency noted in this bug is fairly simple, but let's see what Rob thinks.
Attachment #8442733 - Flags: review?(rcampbell)
Assignee: nobody → past
Status: NEW → ASSIGNED
(In reply to Panos Astithas [:past] from comment #3) > I'm not sure who implemented this behavior, but my guess is that the thought > must have been that an inline comment is more "lightweight". It might be Bug 690552. (I don’t know whether this bug included the "Inspect" feature. In some execution modes when the result was an exception it went to the Error Console or Web Console, and it was changed so that exceptions would be written as comments in the scratchpad instead.)
an inline comment is easy to use, easy to implement and easy to copy and paste elsewhere. Adding an "output" panel is going to open up a slew of follow-up bugs to implement all of our nice formatting features from the web console and elsewhere. It also blurs the lines between the scratchpad and the console. I still don't like this.
Comment on attachment 8442733 [details] [diff] [review] Inspect primitive values in the object inspector instead of as inline comments Does this need a test?
Attachment #8442733 - Flags: review?(rcampbell) → review+
Yep, here is a test. Try: https://tbpl.mozilla.org/?tree=Try&rev=4ffa00b643cb
Attachment #8442733 - Attachment is obsolete: true
(In reply to Rob Campbell [:rc] (:robcee) from comment #6) > Adding an "output" panel is going to open up a slew of > follow-up bugs to implement all of our nice formatting features from the web > console and elsewhere. Is it probable that there would be many such requests? And couldn't they be WONTFIXed easily ("As of now we have no plans to extend that part of Scratchpad. You can use X instead."), if need be? I'd suggest not using a generic heading such as "Output" ("An Output pane in Scratchpad? Let's do a bucketload of new stuff with it!"), and instead using the result's type (or nothing). string "the string" number 421 > It also blurs the lines between the scratchpad and the console. Perhaps, but isn’t the line blurred by the availability of an “Inspect” function (and the same Object Inspector as in the console) to begin with? Not sure this changes anything in that respect.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.