1027425 - Clean up static initializers for proxy handler instances

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Eric Faust [:efaust]]

We have all these singleton instances of C++ Proxy Handlers laying around, and calling static initializers for them is silly, and costly for b2g, as I understand it.

Some months ago, I told Nathan he was gonna ruin a patch of mine if he went forward with fixing this, and that I would take care of it. Now that we're doing bug 1027402, this should be pretty straight forward

Comment 1

[Eric Faust [:efaust]]

Attachment: Patch

Finally do what I promised forever ago. I will push this stack to try as soon as it reopens and post here.

r? froydnj to ensure someone who knows all the ins and outs takes a look at this.

Comment 2

[Eric Faust [:efaust]]

Attachment: Patch v2

Fix some failures seen on try after I was finally able to push. This patch, as well as those from the two open blockers on try at https://tbpl.mozilla.org/?tree=Try&rev=d6dee568944f

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8477812 [details] [diff] [review]
Patch v2

Should jswrapper really be using aFoo arg names?

The WaiveXrayWrapper ctor should be explicit, I'd hope.

Why did a bunch of the Xray helper classes move to the header?  Is it just so we can make XrayWrapper have a constexpr ctor?  That seems really annoying.  :(  Can we just leave it be?

r=me on the rest, but I'd like to understand what the deal is with the Xray changes.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8477812 [details] [diff] [review]
Patch v2

Review of attachment 8477812 [details] [diff] [review]:
-----------------------------------------------------------------

Worth explicitly noting that this won't help B2G until we upgrade the (Gecko) compiler for B2G, since GCC < 4.6 doesn't support constexpr...but at least everybody else benefits in the interim!

Comment 5

[Eric Faust [:efaust]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f41c1edabfe8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f41c1edabfe8