Test plugins are not built in gtk3 builds

RESOLVED FIXED in mozilla33

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla33
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
As a consequence, several tests are broken.
(Assignee)

Updated

4 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 1

4 years ago
Created attachment 8442621 [details] [diff] [review]
Build test plugins when building with --enable-default-toolkit=cairo-gtk3
Attachment #8442621 - Flags: review?(mshal)
Comment on attachment 8442621 [details] [diff] [review]
Build test plugins when building with --enable-default-toolkit=cairo-gtk3

>+elif toolkit in ('gtk2', 'gtk3'):
>     UNIFIED_SOURCES += [
>         relative_path + '/nptest_gtk2.cpp',

I guess we don't need a specific nptest_gtk3.cpp?
Attachment #8442621 - Flags: review?(mshal) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Michael Shal [:mshal] (no reviews until 6/30) from comment #2)
> I guess we don't need a specific nptest_gtk3.cpp?

No, and in fact, the gtk3 build builds gtk2 plugins.

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/2e2d182304f6
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

Updated

4 years ago
Blocks: 1034064

Updated

4 years ago
No longer blocks: 1034064
You need to log in before you can comment on or make changes to this bug.