1027547 - [Vertical Homescreen] [Smart collections] Context menu is displayed long pressing empty spaces

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Cristian Rodriguez (:crdlc)]

E/GeckoConsole( 9814): [JavaScript Error: "TypeError: icon is undefined" {file: "app://collection.gaiamobile.org/js/contextmenu.js" line: 34}]

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

thanks

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8442716 [details]
Github pull request

Awesome

Comment 3

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/4f3019ca9325dac282e3d910d2a7ad9d84e0579c

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8442716 [details]
Github pull request

Needed for the vertical homescreen.

Comment 5

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/060a9050dcd7475c3940ce16421ea28e6ed2241b

Comment 6

[sarsenyev]

Verified the issue is fixed on 2.2, 2.1 and 2.0
Content menu is not displayed when pressing empty spaces in collections 

Device: Flame 2.2 Master KK
BuildID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1 KK
BuildID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Device 2.0 KK
BuildID: 20141027000202
Gaia: 2183b4f3ec0eb47ab1f133c31732ec53b08ad253
Gecko: 43bee45176c4
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0