some unused const variables in PSM causing build to fail with --enable-warnings-as-errors

RESOLVED FIXED in mozilla33

Status

()

Core
Security: PSM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: keeler, Assigned: keeler)

Tracking

unspecified
mozilla33
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

security/manager/ssl/src/SSLServerCertVerification.cpp has this that isn't used:

NS_DEFINE_CID(kNSSComponentCID, NS_NSSCOMPONENT_CID);

security/manager/ssl/src/nsKeygenHandler.cpp has this that isn't used:

static NS_DEFINE_IID(kIDOMHTMLSelectElementIID, NS_IDOMHTMLSELECTELEMENT_IID);

This causes my build to fail with --enable-warnings-as-errors (which I thought was enabled on the trees, so I'm not sure why those aren't failing as well).
Created attachment 8442910 [details] [diff] [review]
patch
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #8442910 - Flags: review?(cviecco)
I guess the issue is they're const, not that they're static.
Summary: some unused static variables in PSM causing build to fail with --enable-warnings-as-errors → some unused const variables in PSM causing build to fail with --enable-warnings-as-errors
(Assignee)

Updated

4 years ago
OS: All → Linux
Hardware: All → x86_64
Attachment #8442910 - Flags: review?(cviecco) → review+
Thanks for the quick review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fefe4c4ffe93
Duplicate of this bug: 1027930
https://hg.mozilla.org/mozilla-central/rev/fefe4c4ffe93
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.