Closed
Bug 1027711
Opened 9 years ago
Closed 9 years ago
some unused const variables in PSM causing build to fail with --enable-warnings-as-errors
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: keeler, Assigned: keeler)
References
Details
Attachments
(1 file)
1.95 KB,
patch
|
cviecco
:
review+
|
Details | Diff | Splinter Review |
security/manager/ssl/src/SSLServerCertVerification.cpp has this that isn't used: NS_DEFINE_CID(kNSSComponentCID, NS_NSSCOMPONENT_CID); security/manager/ssl/src/nsKeygenHandler.cpp has this that isn't used: static NS_DEFINE_IID(kIDOMHTMLSelectElementIID, NS_IDOMHTMLSELECTELEMENT_IID); This causes my build to fail with --enable-warnings-as-errors (which I thought was enabled on the trees, so I'm not sure why those aren't failing as well).
![]() |
Assignee | |
Comment 1•9 years ago
|
||
![]() |
Assignee | |
Comment 2•9 years ago
|
||
I guess the issue is they're const, not that they're static.
Summary: some unused static variables in PSM causing build to fail with --enable-warnings-as-errors → some unused const variables in PSM causing build to fail with --enable-warnings-as-errors
![]() |
Assignee | |
Updated•9 years ago
|
OS: All → Linux
Hardware: All → x86_64
Updated•9 years ago
|
Attachment #8442910 -
Flags: review?(cviecco) → review+
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Thanks for the quick review. https://hg.mozilla.org/integration/mozilla-inbound/rev/fefe4c4ffe93
https://hg.mozilla.org/mozilla-central/rev/fefe4c4ffe93
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•