Report unique device name from discovery

RESOLVED FIXED in Firefox 33

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
Firefox 33
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Device discovery currently uses the host name / Android device name as the device name it sends out, which then appears in the runtime list.

If you have multiple devices with the same name, then there's no way to tell them apart at the moment.  Should more info to the name or something to help discriminate.  Or perhaps expose b2g version, etc.?
Paul, this gives a more unique name on b2g, such as "flame-1234abcd", instead of just "flame".

This would become important anywhere there are many b2g devices on the same local network (like most Mozilla offices I would guess!).

Try: https://tbpl.mozilla.org/?tree=Try&rev=ef1e7e43fdc5
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8452565 - Flags: review?(paul)
Fix test failure.

Try: https://tbpl.mozilla.org/?tree=Try&rev=ee8184891aa7
Attachment #8452565 - Attachment is obsolete: true
Attachment #8452565 - Flags: review?(paul)
Attachment #8452670 - Flags: review?(paul)
Comment on attachment 8452670 [details] [diff] [review]
Unique device discovery names for b2g (v2)

To get the settings, use "@mozilla.org/settingsService;1". For example: http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/device.js#58

I'll finish the review next week.
Comment on attachment 8452670 [details] [diff] [review]
Unique device discovery names for b2g (v2)

Review of attachment 8452670 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/discovery/discovery.js
@@ +149,5 @@
> + */
> +function LocalDevice() {
> +  this._name = LocalDevice.UNKNOWN;
> +  if (window) {
> +    this._settings = window.navigator.mozSettings;

As mentioned in previous comment, don't use `window`, but the service.
Attachment #8452670 - Flags: review?(paul) → review+
Blocks: 1039449
Updated to use SettingsService instead of mozSettings from a window.

Try: https://tbpl.mozilla.org/?tree=Try&rev=948a0af5e70d
Attachment #8452670 - Attachment is obsolete: true
Attachment #8456853 - Flags: review+
Fixed test failure.

Try: https://tbpl.mozilla.org/?tree=Try&rev=fb38634547ef
Attachment #8456853 - Attachment is obsolete: true
Attachment #8457407 - Flags: review+
Try is quite colorful, but looks like all issues were infra problems or known intermittents.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/c6f27c773336
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c6f27c773336
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.