1027787 - Report unique device name from discovery

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Device discovery currently uses the host name / Android device name as the device name it sends out, which then appears in the runtime list.

If you have multiple devices with the same name, then there's no way to tell them apart at the moment.  Should more info to the name or something to help discriminate.  Or perhaps expose b2g version, etc.?

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Unique device discovery names for b2g

Paul, this gives a more unique name on b2g, such as "flame-1234abcd", instead of just "flame".

This would become important anywhere there are many b2g devices on the same local network (like most Mozilla offices I would guess!).

Try: https://tbpl.mozilla.org/?tree=Try&rev=ef1e7e43fdc5

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Unique device discovery names for b2g (v2)

Fix test failure.

Try: https://tbpl.mozilla.org/?tree=Try&rev=ee8184891aa7

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 8452670 [details] [diff] [review]
Unique device discovery names for b2g (v2)

To get the settings, use "@mozilla.org/settingsService;1". For example: http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/device.js#58

I'll finish the review next week.

Comment 4

[Paul Rouget [:paul]]

Comment on attachment 8452670 [details] [diff] [review]
Unique device discovery names for b2g (v2)

Review of attachment 8452670 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/discovery/discovery.js
@@ +149,5 @@
> + */
> +function LocalDevice() {
> +  this._name = LocalDevice.UNKNOWN;
> +  if (window) {
> +    this._settings = window.navigator.mozSettings;

As mentioned in previous comment, don't use `window`, but the service.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Unique device discovery names for b2g (v3, paul: r+)

Updated to use SettingsService instead of mozSettings from a window.

Try: https://tbpl.mozilla.org/?tree=Try&rev=948a0af5e70d

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Unique device discovery names for b2g (v4, paul: r+)

Fixed test failure.

Try: https://tbpl.mozilla.org/?tree=Try&rev=fb38634547ef

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Unique device discovery names for b2g (v5, paul: r+)

More test failures fixed.

Try: https://tbpl.mozilla.org/?tree=Try&rev=5b9419529fed

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try is quite colorful, but looks like all issues were infra problems or known intermittents.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c6f27c773336

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c6f27c773336