1027790 - Bare Metal Provisioning 2008 Puppet: Windows cmd line configuration manifest

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Comment 1

[Mark Cornmesser [:markco]]

Selected Feedback from 979540 for patch submitted on 2014-06-11 regarding registry:

> ::: modules/registry/manifests/2008/disable_moz_svc_cert.pp
> @@ +1,1 @@
> > +# This Source Code Form is subject to the terms of the Mozilla Public
> 
> If the registry module comes from the puppetforge, it should be included
> verbatim.  Anything Mozilla-specific should be in another module.  Some of
> these can, I think, be used from other existing modules, but most will
> probably fit well into the 'tweaks' module.
> 
> @@ +1,4 @@
> > +# This Source Code Form is subject to the terms of the Mozilla Public
> > +# License, v. 2.0. If a copy of the MPL was not distributed with this
> > +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> > +# All buildbot slaves (both build and test) are subclasses of this class.
> 
> Not accurate ;)
> 
> @@ +5,5 @@
> > +
> > +class registry::2008::disable_moz_svc_cert {
> > +    exec {'moz_svc-cer1':
> > +        command => 'c:\Windows\System32\reg.exe delete HKLM\SOFTWARE\Mozilla\MaintenanceService\3932ecacee736d366d6436db0f55bce4\1 /v issuer /f',
> > +    }
This particular manifest is not needed. Cert is not longer being installed.

Comment 2

[Mark Cornmesser [:markco]]

> ::: modules/winconfig/manifests/2008/cleanmgr.pp
> @@ +6,5 @@
> > +class winconfig::2008::cleanmgr {
> > +    #Enables Clean Desktop Exp. managaer. See  http://technet.microsoft.com/en-us/library/ee344834.aspx for refrence.
> > +    exec { "cleanmgr":
> > +        command => 'C:\Windows\System32\servermanagercmd.exe -install Desktop-Experience -resultPath results.xml'
> > +    }
> 
> I think this sets the system to login to the old-style desktop?  If so, this
> should probably be a part of users::builder::autologin.
> 

Has been moved to users::builder::autologin

...
        #Enables Clean Desktop Exp. managaer. See  http://technet.microsoft.com/en-us/library/ee344834.aspx for refrence.
            exec { "cleanmgr":
                creates => 'C:\programdata\PuppetLabs\puppet\var\lib\results.xml',
                command => 'C:\Windows\System32\servermanagercmd.exe -install Desktop-Experience -resultPath C:\programdata\PuppetLabs\puppet\var\lib\results.xml',
            }
...

Comment 3

[Mark Cornmesser [:markco]]

> ::: modules/winconfig/manifests/2008/winreport.pp
> @@ +4,5 @@
> > +# All buildbot slaves (both build and test) are subclasses of this class.
> > +
Line removed and manifest moved to disableservices::winreport
> > +class winconfig::2008::winreport {
> > +    #Disable Windows reporting service
> > +    service { "Windows Error Reporting Service":
> 
> Should probably move to the tweaks module
> 
Has been moved to disable services module since relaying on the service resource.

Comment 4

[Mark Cornmesser [:markco]]

> ::: modules/winconfig/manifests/allwindows/disable_ms_maintenance.pp
> @@ +3,5 @@
> > +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> > +# All buildbot slaves (both build and test) are subclasses of this class.
> > +
> > +class winconfig::allwindows::disable_ms_maintenance {
> > +    #Disable Microsoft schedule maintenance. Refer to http://technet.microsoft.com/en-us/library/cc725744.aspx for schtasks
> 
> move to disableservices
> 

Moved to disable services module. However, this is not applicable to 2008.

Comment 5

[Mark Cornmesser [:markco]]

> ::: modules/winconfig/manifests/allwindows/hddoff.pp
> @@ +3,5 @@
> > +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> > +# All buildbot slaves (both build and test) are subclasses of this class.
> > +
> > +class winconfig::allwindows::hddoff {
> > +    #Set Power option to High Performance. Refer to http://technet.microsoft.com/en-us/library/cc748940%28v=ws.10%29.aspx for powercfg.exe
> 
> How is this different from 2008::hddoff?
> @@ +5,5 @@
> > +
> > +class winconfig::allwindows::hddoff {
> > +    #Set Power option to High Performance. Refer to http://technet.microsoft.com/en-us/library/cc748940%28v=ws.10%29.aspx for powercfg.exe
> > +    exec { "hddoff":
> > +        command => "C:\Windows\System32\powercfg.exe /change disk-timeout-ac 0"
> 
> I think this has some parallels in the 'hardware' module.

No difference removed one, and moved the other to hardware module. 

class hardware::hddoff {
    #Disable harddrive timeout. Refer to http://technet.microsoft.com/en-us/library/cc748940%28v=ws.10%29.aspx
    exec { "hddoff":
        command => '"C:\Windows\System32\powercfg.exe" /change disk-timeout-ac 0'
    }
    file {
            'C:\programdata/PuppetLabs/puppet/var/lib/hddoff.txt':
                require => Exec["hddoff"],
                content => "Semaphore",
    }
}

Comment 6

[Mark Cornmesser [:markco]]

 ::: modules/winconfig/manifests/allwindows/highperformance.pp
> @@ +3,5 @@
> > +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> > +# All buildbot slaves (both build and test) are subclasses of this class.
> > +
> > +class winconfig::allwindows::highperformance {
> > +    #Set Power option to High Performance. Refer to http://technet.microsoft.com/en-us/library/cc748940%28v=ws.10%29.aspx
> 
> Ditto - either 'hardware' or 'tweaks'.

Moved to hardware module:
class hardware::highperformance {
    #Set Power option to High Performance. Refer to http://technet.microsoft.com/en-us/library/cc748940%28v=ws.10%29.aspx
    exec { "highperformance":
        creates => 'C:\programdata\PuppetLabs\puppet\var\lib\highperformance.txt',
        command => '"C:\Windows\System32\powercfg.exe" -setactive 8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c',
    }
    file {
            'C:\programdata/PuppetLabs/puppet/var/lib/highperformance.txt':
                require => Exec["highperformance"],
                content => "Semaphore",
    }

Comment 7

[Mark Cornmesser [:markco]]

pwrshellopt.pp has been moved to tweak module : 

class tweaks::pwrshellopt {
    #Set powershell option to allow all poershell scripts to be ran. Refer to http://technet.microsoft.com/en-us/library/ee176961.aspx.
    exec { "pwrshellopt":
        creates => 'C:\programdata/PuppetLabs/puppet/var/lib/pwrshellopt.txt',
        command => '"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -noprofile Set-ExecutionPolicy Unrestricted',
    }
    file {
            'C:\programdata/PuppetLabs/puppet/var/lib/pwrshellopt.txt':
                require => Exec["pwrshellopt"],
                content => "Semaphore",
    }
}

Comment 8

[Mark Cornmesser [:markco]]

Eliminated the winconfig module and added a create and file creation for semaphore to ensure run once. Unless there was a file created by the command line. Creates will then reflect that file.