Closed Bug 1027792 Opened 10 years ago Closed 10 years ago

The `linkAnimation` and `linkSelection` methods in CanvasGraphUtils should first check if graphs are actually available

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file)

This came up while I was working on bug 879008. Sometimes, graphs aren't available because there's not enough data to draw them. It'd be more elegant if the `linkAnimation` and `linkSelection` methods would gracefully handle such cases in which one graph isn't available, instead of API consumers having this responsibility.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8442997 - Flags: review?(pbrosset)
Attachment #8442997 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/533f9bd05058
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: