Closed Bug 1027848 Opened 12 years ago Closed 12 years ago

Remove obsolete shell command-line options

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: sunfish, Assigned: sunfish)

Details

Attachments

(1 file)

obsolete-options.patch
2.00 KB, patch
h4writer
: review+
gkw
: feedback+
Details | Diff | Splinter Review
The attached patch removes a few JM-era command-line options which have been obsolete for a while now: --jm, --no-jm, and --always-mjit.
Attachment #8443030 - Flags: review?(gary)
Comment on attachment 8443030 [details] [diff] [review] obsolete-options.patch We've removed use of the old JM flags for recent js shells, so feedback+ from me. You'd have to ask for review from a JS JIT folks though. :)
Attachment #8443030 - Flags: review?(gary) → feedback+
Comment on attachment 8443030 [details] [diff] [review] obsolete-options.patch Review of attachment 8443030 [details] [diff] [review]: ----------------------------------------------------------------- Just a simple patch cleaning up old command-line options.
Attachment #8443030 - Flags: review?(hv1989)
Comment on attachment 8443030 [details] [diff] [review] obsolete-options.patch Review of attachment 8443030 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense. Jaegermonkey is long gone and this was only kept for the fuzzers. So let us finally remove that. Thanks for giving the review to me. I quickly checked the awfy slaves and they are now also free from these flags.
Attachment #8443030 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/9a363e5ef917
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: