Closed
Bug 1027866
Opened 10 years ago
Closed 10 years ago
Asserts to guard against inserting an item into an InlineList twice
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: sunfish, Assigned: sunfish)
Details
Attachments
(1 file)
|
4.84 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
The attached patch adds asserts to catch the case where a node which is already contained in an inline list is re-inserted. This replaces a less-effective assert in MNode::addUse. The patch also adds an unchecked path for the one place that needs it.
Attachment #8443060 -
Flags: review?(jdemooij)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8443060 [details] [diff] [review] inlinelist-asserts.patch Review of attachment 8443060 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8443060 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/076fec14c542
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/076fec14c542
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•