Asserts to guard against inserting an item into an InlineList twice

RESOLVED FIXED in mozilla33

Status

()

Core
JavaScript Engine: JIT
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sunfish, Assigned: sunfish)

Tracking

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8443060 [details] [diff] [review]
inlinelist-asserts.patch

The attached patch adds asserts to catch the case where a node which is already contained in an inline list is re-inserted. This replaces a less-effective assert in MNode::addUse.

The patch also adds an unchecked path for the one place that needs it.
Attachment #8443060 - Flags: review?(jdemooij)
Comment on attachment 8443060 [details] [diff] [review]
inlinelist-asserts.patch

Review of attachment 8443060 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8443060 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/076fec14c542
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.