The default bug view has changed. See this FAQ.

Use tooltool for l10n builds

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Assignee)

Description

3 years ago
l10n builds should use tooltool on all platforms, using a l10n.manifest file.
(Assignee)

Comment 1

3 years ago
The interesting thing is that afaict, release l10n repacks are actually using tooltool (and using the same manifest as normal builds, which is arguably overkill)
(Assignee)

Comment 2

3 years ago
release l10n repacks are using tooltool, but they're not running it from the top source directory like other builds, so all assumtions about tooltool tools paths are wrong, which makes release l10n builds not use mozmake despite it being downloaded by tooltool.
(Assignee)

Comment 3

3 years ago
Created attachment 8443180 [details] [diff] [review]
Run tooltool from within the source directory during l10n repacks

Bug 902084 added tooltool to l10n repacks to get mac builds to use clang, but the fact is the builds never actually picked clang from tooltool and the failures must have been fixed some other way. But since I do want l10n builds to use tooltool, might as well do that properly.
Attachment #8443180 - Flags: review?(nthomas)
(Assignee)

Updated

3 years ago
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 4

3 years ago
Created attachment 8443185 [details] [diff] [review]
Use a dedicated tooltool manifest for l10n repacks

Since l10n repacks never actually used tooltool-downloaded stuff, might as well avoid the overkill-ness of downloading the same things as normal builds and use a different tooltool manifest.
Attachment #8443185 - Flags: review?(nthomas)
(Assignee)

Comment 5

3 years ago
Created attachment 8443191 [details] [diff] [review]
Add l10n tooltool manifests

AIUI, android builds use a different config for tooltool.
Attachment #8443191 - Flags: review?(nthomas)
(Assignee)

Updated

3 years ago
Attachment #8443180 - Attachment is obsolete: true
Attachment #8443180 - Flags: review?(nthomas)
(Assignee)

Updated

3 years ago
Attachment #8443180 - Attachment is obsolete: false
Attachment #8443180 - Flags: review?(nthomas)
(Assignee)

Comment 6

3 years ago
Created attachment 8443207 [details] [diff] [review]
Add tooltool step to nightly repacks
Attachment #8443207 - Flags: review?(nthomas)
(Assignee)

Comment 7

3 years ago
Created attachment 8443276 [details] [diff] [review]
Add tooltool step to nightly repacks

After testing on staging, it appears it needed an adjustment for the workdir to be right during repacks.
Attachment #8443276 - Flags: review?(nthomas)
(Assignee)

Updated

3 years ago
Attachment #8443207 - Attachment is obsolete: true
Attachment #8443207 - Flags: review?(nthomas)
(Assignee)

Comment 8

3 years ago
Created attachment 8443278 [details] [diff] [review]
Add l10n tooltool manifests

Adding to comm-central configs too.
Attachment #8443278 - Flags: review?(nthomas)
(Assignee)

Updated

3 years ago
Attachment #8443191 - Attachment is obsolete: true
Attachment #8443191 - Flags: review?(nthomas)
(Assignee)

Comment 9

3 years ago
Validated with release l10n repacks and nightly l10n repacks on staging.
(Assignee)

Updated

3 years ago
Depends on: 1028100

Updated

3 years ago
Attachment #8443180 - Flags: review?(nthomas) → review+

Updated

3 years ago
Attachment #8443185 - Flags: review?(nthomas) → review+

Updated

3 years ago
Attachment #8443276 - Flags: review?(nthomas) → review+
Comment on attachment 8443278 [details] [diff] [review]
Add l10n tooltool manifests

Thanks for taking the effort to test these changes. 

re the earlier conversation about release mac l10n, are you planning to create browser/config/tooltool-manifests/macosx64/l10n.manifest ?
Attachment #8443278 - Flags: review?(nthomas) → review+
(Assignee)

Comment 11

3 years ago
(In reply to Nick Thomas [:nthomas] from comment #10)
> Comment on attachment 8443278 [details] [diff] [review]
> Add l10n tooltool manifests
> 
> Thanks for taking the effort to test these changes. 
> 
> re the earlier conversation about release mac l10n, are you planning to
> create browser/config/tooltool-manifests/macosx64/l10n.manifest ?

Considering we're barely building code during l10n, now, and that it works fine with system clang, I'm not convinced it's worth much.
(Assignee)

Comment 12

3 years ago
https://hg.mozilla.org/build/buildbot-configs/rev/f1afbbb2db7b
https://hg.mozilla.org/build/tools/rev/d5ad563df856
https://hg.mozilla.org/build/buildbotcustom/rev/ce95864ba1b9
https://hg.mozilla.org/build/buildbotcustom/rev/39fd5b73b6c6
(Assignee)

Comment 13

3 years ago
In production
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.